Speed up yarn lint
#1796
Merged
Speed up yarn lint
#1796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This speeds up the overall performance of running `yarn lint` on most machines. Lint alone on my machine takes ~109s. TSC takes another ~30s. When run in series this is over 2min. However, when run in parallel, the entire command only takes ~109s, in otherwords only as long as the longest process.
|
Build successful! 🎉 |
1 similar comment
|
Build successful! 🎉 |
devongovett
approved these changes
Apr 19, 2021
majornista
pushed a commit
to majornista/react-spectrum-v3
that referenced
this pull request
May 19, 2021
This speeds up the overall performance of running `yarn lint` on most machines. Lint alone on my machine takes ~109s. TSC takes another ~30s. When run in series this is over 2min. However, when run in parallel, the entire command only takes ~109s, in otherwords only as long as the longest process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up the overall performance of running
yarn linton most machines. Lint alone on my machine takes ~109s. TSC takes another ~30s. When run in series this is over 2min. However, when run in parallel, the entire command only takes ~109s, in otherwords only as long as the longest process.In our pipeline, the difference is slightly less noticeable ~15s of savings
However, since it's still eslint that is taking the longest, we only have to address that one to get full savings. The other two do not matter in this scenario.
Another added benefit though is that if you fail any step, you'll still get the results of the other two tasks. So you won't fix typescript only to be surprised with a lint error.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: