Updating combobox docs to explain onOpenChange changes #1806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LFDanLu
requested review from
dannify,
devongovett and
snowystinger
as code owners
Member
Author
|
DNM untill #1749 is merged |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
snowystinger
approved these changes
Apr 26, 2021
Member
snowystinger
left a comment
snowystinger
left a comment
There was a problem hiding this comment.
Lgtm! I can fully open it manually or see the filtered list while typing
devongovett
approved these changes
Apr 30, 2021
Member
|
Looks good. DNM until release is out. |
majornista
pushed a commit
to majornista/react-spectrum-v3
that referenced
this pull request
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
Followup to #1749
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: