Skip to content

Moving default focus behavior from Menu into useSelectableCollection #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Feb 28, 2020
Merged

Moving default focus behavior from Menu into useSelectableCollection #211

merged 24 commits into from
Feb 28, 2020

Conversation

@LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Feb 19, 2020 •
edited
Loading

Closes https://jira.corp.adobe.com/browse/RSP-1399

✅ Pull Request Checklist:

  • Included link to corresponding Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exist for this component).
  • Looked at the Accessibility Standard and/or talked to @mijordan about Accessibility for this feature.

📝 Test Instructions:

Go to the default MenuTrigger story (https://reactspectrum.blob.core.windows.net/reactspectrum/7fd54d21d8edae29f59a62f287f1ca63aa78d665/storybook/index.html?path=/story/menutrigger--default) and verify that the following interactions work still:

  • clicking on the trigger button causes the menu to open and focuses the first item
  • focusing the trigger button and hitting Space/Enter/ArrowDown causes the menu to open and focuses the first item
  • focusing the trigger button and hitting ArrowUp causes the menu to open and focuses the last item
  • opening a menu that has a selected item causes the selected item to be focused regardless of the method used to open the menu
  • you can "wrap around" to the top/bottom item when navigating through the menu list via arrow up/down

Go to Menu/Tree/ButtonGroup/other components that use useSelectableCollection stories and verify that none of the items are autofocused on render

@LFDanLu LFDanLu changed the base branch from master to v3_menu_items_2 February 19, 2020 23:11
@adobe-bot
Copy link

adobe-bot commented Feb 21, 2020

Build successful! 🎉

@LFDanLu LFDanLu changed the title (WIP) Moving default focus behavior from Menu into useSelectableCollection Moving default focus behavior from Menu into useSelectableCollection Feb 21, 2020
@devongovett devongovett changed the base branch from v3_menu_items_2 to master February 28, 2020 21:03
@LFDanLu LFDanLu changed the base branch from master to v3_menu_items_2 February 28, 2020 21:11
LFDanLu added 21 commits February 28, 2020 13:25
@LFDanLu
Adding useMenuItem aria hook
8ce06ac
@LFDanLu
Initial conversion to use semantic elements and grid css
0ed9c06
@LFDanLu
Updating multiselect menuitem to have checkboxes and supporting keybo…
aa2ecab 
…ard icons

also assorted package json fixes and updates
@LFDanLu
Cleaning up comments and updating stories
d10671e
@LFDanLu
WIP Menu Checkbox and Switch support
89a28c6 
has onPress added to Switch and Checkbox so that clicking on the Checkbox doesn
@LFDanLu
Adding closeOnSelect and replacing setOpen call in MenuItems with onC…
4f5e222 
…lose from MenuTrigger
@LFDanLu
fixing lint and passing closeOnSelect down to menu item
ba142a0
@LFDanLu
Updating menutrigger test to use v3 menu
84d7b64
@LFDanLu
Removing checkbox multiselect and switch examples
e8cfc36
@LFDanLu
Updating MenuTrigger tests to use v3 Menu
a70b6f2
@LFDanLu
Adding some more menuTrigger tests
b431b2c
@LFDanLu
fixing lint and removing some stragglers from checkbox/switch menu it…
b10ea69 
…em design
@LFDanLu
Making menuitem selection via ENTER always close menu
065c54e
@LFDanLu
Changing menu grid area to match keyboard and text element default slots
973658e
@LFDanLu
initial port of focus useEffect from Menu to useSelectableCollection
1a5f19b
@LFDanLu
Adding wrapAround input param to useSelectableCollection
e62fbdc
@LFDanLu
changing autofocus default to false
eb64280
@LFDanLu
updates from design review meeting
0f13c76 
removing setFocusStategy from being passed into Menu and changing default of wrapAround
@LFDanLu
skipping focus logic if autofocus is false
1d1e540
@LFDanLu
Fixing menu tests
5d438a4
@LFDanLu
Only set manager focus if autoFocus is true
280fba7
@LFDanLu LFDanLu changed the base branch from v3_menu_items_2 to master February 28, 2020 22:15
@adobe-bot
Copy link

adobe-bot commented Feb 28, 2020

Build successful! 🎉

@adobe-bot
Copy link

adobe-bot commented Feb 28, 2020

Build successful! 🎉

@devongovett devongovett merged commit 0246daa into master Feb 28, 2020
@devongovett devongovett deleted the RSP-1399 branch February 28, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devongovett devongovett devongovett approved these changes

@dannify dannify Awaiting requested review from dannify

@snowystinger snowystinger Awaiting requested review from snowystinger

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LFDanLu @adobe-bot @devongovett