Chromatic adding some Arabic, Chinese, and Japanese string to test fonts #2155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktabors
requested review from
dannify,
devongovett and
snowystinger
as code owners
|
Build successful! 🎉 |
solimant
previously approved these changes
Aug 4, 2021
packages/@react-spectrum/menu/chromatic/MenuTrigger.chromatic.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: solimant <solimant@users.noreply.github.com>
Co-authored-by: solimant <solimant@users.noreply.github.com>
|
Build successful! 🎉 |
|
Build successful! 🎉 |
LFDanLu
requested changes
Aug 6, 2021
Comment on lines
152
to
162
| export const TemplateArabicWithIcons = (): Story<SpectrumMenuTriggerProps> => (args) => ( | ||
| <MenuTrigger {...args} isOpen> | ||
| <ActionButton> | ||
| Menu Button | ||
| </ActionButton> | ||
| <Menu items={withArabic}> | ||
| {item => customMenuItem(item)} | ||
| </Menu> | ||
| </MenuTrigger> | ||
| ); | ||
|
|
There was a problem hiding this comment.
This one isn't rendering in the MenuTrigger chromatic story. Instead of exporting this and importing it in the RTL chromatic story you could do the following:
const TemplateArabicWithIcons = (): Story<SpectrumMenuTriggerProps> => (args) => (
<MenuTrigger {...args} isOpen>
<ActionButton>
Menu Button
</ActionButton>
<Menu items={withArabic}>
{item => customMenuItem(item)}
</Menu>
</MenuTrigger>
);
...
export const TemplateArabic = TemplateArabicWithIcons().bind({});
TemplateArabic.storyName = 'Arabic complex items';
and in MenuTriggerRTL file:
export {
TemplateArabic,
Default,
WithSections,
Complex,
AlignEnd,
DirectionTop,
DirectionBottom,
DirectionStart,
DirectionStartEnd,
DirectionEnd,
DirectionLeft,
DirectionLeftEnd,
DirectionRight,
DirectionRightEnd
} from './MenuTrigger.chromatic';
|
Build successful! 🎉 |
|
Build successful! 🎉 |
There was a problem hiding this comment.
TextArea:value: 測試, icon: Info, labelPosition: side, validationState: valid
doesn't quite fit
nor does
Textfield:value: 測試, icon: Info, labelPosition: side, validationState: valid
I know we have a few that don't fit already, but I want to try to not introduce new ones
The rest look fine
|
Build successful! 🎉 |
LFDanLu
approved these changes
Sep 4, 2021
|
Build successful! 🎉 |
snowystinger
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no issue, but related to #1094 to making testing #2057 with chromatic better
adding Arabic, Chinese, and Japanese strings and locales to Chromatic tests to make sure everything with the improved font-family handling is better.
✅ Pull Request Checklist:
📝 Test Instructions:
added Chinese, Japanese, and Arabic strings to button, menu, and textfield stories within chromatic
🧢 Your Project:
RSP