Skip to content

correctly handle domProps in useNumberField #2453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2021
Merged

correctly handle domProps in useNumberField #2453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d11348a
correctly handle domProps in useNumberField
Oct 15, 2021
8ee392c
Merge branch 'main' into useNumberField-data-attrs
dannify Oct 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/@react-aria/numberfield/src/useNumberField.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

import {AriaButtonProps} from '@react-types/button';
import {AriaNumberFieldProps} from '@react-types/numberfield';
import {filterDOMProps, isAndroid, isIOS, isIPhone, mergeProps, useId} from '@react-aria/utils';
import {
HTMLAttributes,
InputHTMLAttributes,
Expand All @@ -23,7 +24,6 @@ import {
} from 'react';
// @ts-ignore
import intlMessages from '../intl/*.json';
import {isAndroid, isIOS, isIPhone, mergeProps, useId} from '@react-aria/utils';
import {NumberFieldState} from '@react-stately/numberfield';
import {TextInputDOMProps} from '@react-types/shared';
import {useFocus, useFocusWithin} from '@react-aria/interactions';
Expand Down Expand Up @@ -172,7 +172,10 @@ export function useNumberField(props: AriaNumberFieldProps, state: NumberFieldSt
state.setInputValue(value);
};

let domProps = filterDOMProps(props);

let {labelProps, inputProps: textFieldProps, descriptionProps, errorMessageProps} = useFormattedTextField({
...domProps,
label,
autoFocus,
isDisabled,
Expand Down
6 changes: 6 additions & 0 deletions packages/@react-spectrum/numberfield/test/NumberField.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2133,6 +2133,12 @@ describe('NumberField', function () {
expect(textField.selectionEnd).toBe(1);
});

it('adds data attributes to textField', () => {
let {textField} = renderNumberField({'data-testid': '123'});

expect(textField).toHaveAttribute('data-testid', '123');
});

describe('locale specific', () => {
describe('spanish (spain)', () => {
it('can determine the group symbol', () => {
Expand Down