Smooth checkbox focus animation #580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you try to scroll in tableview with the arrow keys while on the checkbox column it becomes very jumpy because of the box-shadow transition Instead, have the box-shadow always there and only change it's opacity We should be doing this to more items... it's a huge savings
|
Build successful! 🎉 |
LFDanLu
approved these changes
Jun 5, 2020
Member
LFDanLu
left a comment
LFDanLu
left a comment
There was a problem hiding this comment.
Compared it to the old storybook, def seems smoother.
devongovett
approved these changes
Jun 5, 2020
|
Build successful! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try to scroll in tableview with the arrow keys while on the checkbox column it becomes very jumpy because of the box-shadow transition
Instead, have the box-shadow always there and only change it's opacity
We should be doing this to more items... it's a huge savings
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: