Skip to content

fix: icon builder ci #8374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 10, 2025
Merged

fix: icon builder ci #8374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3538593
fix: verdaccio icon builder test
snowystinger Jun 10, 2025
5d4025e
turn on verdaccio
snowystinger Jun 10, 2025
8ded855
loosen another range
snowystinger Jun 10, 2025
05e9b51
one more
snowystinger Jun 10, 2025
c2039d0
add debugging statements
snowystinger Jun 10, 2025
2589f25
more debugging
snowystinger Jun 10, 2025
3ead1c5
revert and change the versioning
snowystinger Jun 10, 2025
52abc4a
fix lock file
snowystinger Jun 10, 2025
ba2db6f
add parcel-namer-s2
snowystinger Jun 10, 2025
756f064
try adding dependency directly
snowystinger Jun 10, 2025
dc1745c
now that we have patches, move back to npx
snowystinger Jun 10, 2025
2302fa7
reset file
snowystinger Jun 10, 2025
59bc7cc
Revert "turn on verdaccio"
snowystinger Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
"@parcel/transformer-svg-react": "^2.14.0",
"@parcel/transformer-typescript-types": "^2.14.0",
"@react-spectrum/parcel-namer-s2": "^0.3.0",
"@react-spectrum/s2-icon-builder": "^0.2.0",
"@react-spectrum/s2-icon-builder": "^0.3.0",
"@spectrum-css/component-builder": "workspace:^",
"@spectrum-css/vars": "^2.3.0",
"@storybook/addon-a11y": "patch:@storybook/addon-a11y@npm%3A^7.6.19#~/.yarn/patches/@storybook-addon-a11y-npm-7.6.19-04b470eae0.patch",
Expand Down
6 changes: 4 additions & 2 deletions scripts/verdaccio-build-icon-builder.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ output="output.out"

set -e

echo "Building docs with verdaccio"
echo "Building icons with verdaccio"

# Wait for verdaccio to start
grep -q 'http address' <(tail -f $output)
Expand Down Expand Up @@ -39,7 +39,9 @@ cd examples/s2-webpack-5-example
mkdir icon-test
cp ../../packages/@react-spectrum/s2/s2wf-icons/S2_Icon_3D_20_N.svg icon-test/S2_Icon_3D_20_N.svg
npx @react-spectrum/s2-icon-builder -i ./icon-test/S2_Icon_3D_20_N.svg -o ./icon-dist
echo 'concluded icon builder'

echo 'testing icon builder library'
mkdir icon-library-test
touch icon-library-test/package.json
cat > icon-library-test/package.json << EOF
Expand All @@ -65,7 +67,7 @@ cat > icon-library-test/package.json << EOF
"react-dom": "^18.0.0 || ^19.0.0-rc.1"
},
"devDependencies": {
"@react-spectrum/s2-icon-builder": ">=0.2.3",
"@react-spectrum/s2-icon-builder": "latest",
"@react-spectrum/s2": "latest",
"react": "^19.0.0",
"react-dom": "^19.0.0"
Expand Down
2 changes: 1 addition & 1 deletion scripts/verdaccio-generate-versions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ process.stdin.on('end', () => {
const packageName = location.split('/').pop();
// Only include specific dev tools
if (['optimize-locales-plugin', 'parcel-resolver-optimize-locales', 'codemods',
'parcel-transformer-s2-icon', 's2-icon-builder', 'ts-plugin'].includes(packageName)) {
'parcel-transformer-s2-icon', 's2-icon-builder', 'ts-plugin', 'parcel-namer-s2'].includes(packageName)) {
acc[workspace.name] = 'patch';
}
return acc;
Expand Down
23 changes: 2 additions & 21 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7940,26 +7940,7 @@ __metadata:
languageName: unknown
linkType: soft

"@react-spectrum/s2-icon-builder@npm:^0.2.0":
version: 0.2.4
resolution: "@react-spectrum/s2-icon-builder@npm:0.2.4"
dependencies:
"@parcel/bundler-library": "npm:^2.14.0"
"@parcel/compressor-raw": "npm:^2.14.0"
"@parcel/core": "npm:^2.14.0"
"@parcel/namer-default": "npm:^2.14.0"
"@parcel/packager-raw": "npm:^2.14.0"
"@parcel/reporter-cli": "npm:^2.14.0"
"@parcel/resolver-default": "npm:^2.14.0"
"@parcel/transformer-raw": "npm:^2.14.0"
"@react-spectrum/parcel-transformer-s2-icon": "npm:^0.3.0"
bin:
transform-icons: index.js
checksum: 10c0/f24669f8351700d547dffe0a1f5030db4ce24f3d952958dcdef8d9d64c11705ab448bbdcc24e864ecd712609b13d31fa1070474b7abed5bca5de986f7515a447
languageName: node
linkType: hard

"@react-spectrum/s2-icon-builder@workspace:packages/dev/s2-icon-builder":
"@react-spectrum/s2-icon-builder@npm:^0.3.0, @react-spectrum/s2-icon-builder@workspace:packages/dev/s2-icon-builder":
version: 0.0.0-use.local
resolution: "@react-spectrum/s2-icon-builder@workspace:packages/dev/s2-icon-builder"
dependencies:
Expand Down Expand Up @@ -27750,7 +27731,7 @@ __metadata:
"@parcel/transformer-svg-react": "npm:^2.14.0"
"@parcel/transformer-typescript-types": "npm:^2.14.0"
"@react-spectrum/parcel-namer-s2": "npm:^0.3.0"
"@react-spectrum/s2-icon-builder": "npm:^0.2.0"
"@react-spectrum/s2-icon-builder": "npm:^0.3.0"
"@spectrum-css/component-builder": "workspace:^"
"@spectrum-css/vars": "npm:^2.3.0"
"@storybook/addon-a11y": "patch:@storybook/addon-a11y@npm%3A^7.6.19#~/.yarn/patches/@storybook-addon-a11y-npm-7.6.19-04b470eae0.patch"
Expand Down