fix: mobile release sorting in new docs #9165
Closed
+37
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LFDanLu
reviewed
Nov 11, 2025
…into fix-mobile-sorting # Conflicts: # packages/dev/s2-docs/src/ComponentCardView.tsx
|
Build successful! 🎉 |
LFDanLu
previously approved these changes
Nov 11, 2025
|
Build successful! 🎉 |
|
Build successful! 🎉 |
reidbarber
previously approved these changes
Nov 11, 2025
LFDanLu
requested changes
Nov 11, 2025
Comment on lines
26
to
27
| <InternalCardViewContext.Provider value={{ElementType: ListBoxItem, layout: 'grid'}}> | ||
| <ListBox |
Member
There was a problem hiding this comment.
I think we need to keep this as a ListBox for the virtual focus to work right? What was broken here that made this change necessary?
Member
Author
There was a problem hiding this comment.
gah, how have so many merges gone wrong in this pr.... i didn't notice this locally it should only have the date in the type
|
Build successful! 🎉 |
reidbarber
approved these changes
Nov 12, 2025
Member
Author
|
closing in favour of #9159 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: