-
Notifications
You must be signed in to change notification settings - Fork 1.4k
docs: more S2 docs fixes #9183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: more S2 docs fixes #9183
Conversation
|
Build successful! 🎉 |
LFDanLu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just gonna push the same fix for the focus visible style, but otherwise looks good to me
|
Build successful! 🎉 |
snowystinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like something might have broken the table of contents links?
https://reactspectrum.blob.core.windows.net/reactspectrum/7cf24e022834598d130e941439144bb745377f4d/s2-docs/s2/getting-started.html#overriding-the-color-scheme
this won't scroll to the right section
|
@snowystinger looks like it broke in #9159. I'll investigate and try to fix it here. |
…-spectrum into s2-docs-beta-2-fixes
|
Build successful! 🎉 |
|
Within a page it works now, but if I go to the link https://reactspectrum.blob.core.windows.net/reactspectrum/48baa8fe5656319c071543aae80dd477fdaa798d/s2-docs/s2/getting-started.html#optimizing-full-page-apps in a new page, it won't scroll to the right position, i'm ok fixing in followup |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
.closest() does not existerror shown in dev if parcel error overlay was focused)✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: