Skip to content

Conversation

@reidbarber
Copy link
Member

@reidbarber reidbarber commented Nov 13, 2025

  • Remove Element assumption from client focus listener (prevents .closest() does not exist error shown in dev if parcel error overlay was focused)
  • Added clipboard copy feedback + message to Illustrations search (same as we have for Icons)
  • Updated search placeholder to change to 'Search Icons' when Icons tag is selected.
  • Silently handle prefetch failures (prevents error message in dev when hovering links that 404)
  • Fix anchor links
  • Don't clear search menu field when switching library tabs
  • Fix anchor links on page load
  • Renders version number in cards for releases

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Nov 13, 2025

Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just gonna push the same fix for the focus visible style, but otherwise looks good to me

LFDanLu
LFDanLu previously approved these changes Nov 13, 2025
@rspbot
Copy link

rspbot commented Nov 13, 2025

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something might have broken the table of contents links?
https://reactspectrum.blob.core.windows.net/reactspectrum/7cf24e022834598d130e941439144bb745377f4d/s2-docs/s2/getting-started.html#overriding-the-color-scheme
this won't scroll to the right section

@reidbarber
Copy link
Member Author

reidbarber commented Nov 13, 2025

@snowystinger looks like it broke in #9159. I'll investigate and try to fix it here.

@rspbot
Copy link

rspbot commented Nov 13, 2025

snowystinger
snowystinger previously approved these changes Nov 13, 2025
@snowystinger
Copy link
Member

Within a page it works now, but if I go to the link https://reactspectrum.blob.core.windows.net/reactspectrum/48baa8fe5656319c071543aae80dd477fdaa798d/s2-docs/s2/getting-started.html#optimizing-full-page-apps in a new page, it won't scroll to the right position, i'm ok fixing in followup

@rspbot
Copy link

rspbot commented Nov 13, 2025

@rspbot
Copy link

rspbot commented Nov 13, 2025

LFDanLu
LFDanLu previously approved these changes Nov 13, 2025
@rspbot
Copy link

rspbot commented Nov 13, 2025

@reidbarber reidbarber added this pull request to the merge queue Nov 14, 2025
Merged via the queue into main with commit 66cbd63 Nov 14, 2025
33 checks passed
@reidbarber reidbarber deleted the s2-docs-beta-2-fixes branch November 14, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants