chore: add links to old docs for hooks we haven't migrated yet #9203
+101
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LFDanLu
reviewed
Nov 18, 2025
| import {InlineAlert, Heading, Content} from '@react-spectrum/s2' | ||
|
|
||
| export const tags = ['hint', 'popup', 'info']; | ||
| export const relatedPages = [{'title': 'useTooltipTrigger', 'url': 'https://react-spectrum.adobe.com/react-aria/useTooltipTrigger.html'}, {'title': 'useTooltip', 'url': 'https://react-spectrum.adobe.com/react-aria/useTooltip.html'}]; |
Member
There was a problem hiding this comment.
useTooltip doesn't exist, it is part of the useTooltipTrigger page, I'll go and update this
LFDanLu
approved these changes
Nov 18, 2025
Member
LFDanLu
left a comment
LFDanLu
left a comment
There was a problem hiding this comment.
LGTM, IMO the mobile experience is fine, no need to add more content since related pages is just a collection of links, hopefully the link titles are explanatory enough
|
Build successful! 🎉 |
|
Build successful! 🎉 |
## API Changes
@react-spectrum/s2/@react-spectrum/s2:EditableCell+EditableCell {
+ action?: string | FormHTMLAttributes<HTMLFormElement>['action']
+ align?: 'start' | 'center' | 'end' = 'start'
+ children: ReactNode
+ colSpan?: number
+ id?: Key
+ isSaving?: boolean
+ onCancel?: () => void
+ onSubmit?: (FormEvent<HTMLFormElement>) => void
+ renderEditing: () => ReactNode
+ showDivider?: boolean
+ textValue?: string
+} |
reidbarber
approved these changes
Nov 21, 2025
Member
reidbarber
left a comment
reidbarber
left a comment
There was a problem hiding this comment.
I'm good with it in its current form, but I have two design opinions:
- Should these be external links? (i.e. have the arrow icon and open in a new tab?)
- For mobile, should it be a bulleted list?
devongovett
approved these changes
Nov 22, 2025
| <H2>Related pages</H2> | ||
| <Ul> | ||
| <H2 id="related-pages">Related pages</H2> | ||
| <Ul className={style({listStyleType: 'none'})}> |
| })}> | ||
| <H2>Related pages</H2> | ||
| <Ul> | ||
| <H2 id="related-pages">Related pages</H2> |
Member
There was a problem hiding this comment.
why id? I think this should be auto-generated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
Adds links to our RAC pages for the underlying hooks used to build those components.
Is the mobile experience ok? it's a bit bare.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: