Skip to content

Conversation

@brenthosie
Copy link
Member

DTM-13847:

  1. Fix the new Data Element supported fields to
    properly translate the value within "formValuesToSettings" blocks.
  2. Consolidate simulate.clear into the test-helpers area.
  3. Update old fireEvent.change calls to userEvent.type calls.

Description

There wasn't enough test coverage to ensure that when translating the formValues into turbine settings, that the data element names weren't always converted to a Number.

Related Issue

https://jira.corp.adobe.com/browse/DTM-13847

Motivation and Context

Adds data element support to many core extension fields that only supported numbers.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All tests pass and I've made any necessary test changes.
  • I have run the extension sandbox successfully.

properly translate the value within "formValuesToSettings" blocks.

Consolidate simulate.clear into the test-helpers area.

Update old fireEvent.change calls to userEvent.type calls.
@brenthosie brenthosie requested review from Aaronius and removed request for Aaronius March 3, 2021 20:24
@brenthosie brenthosie marked this pull request as draft March 5, 2021 17:18
from DTM-13847 to accept the data element names.
@brenthosie brenthosie force-pushed the DTM-13847-fix-fields-to-settings branch from a67f402 to 9bfac9a Compare March 5, 2021 17:51
@brenthosie brenthosie marked this pull request as ready for review March 9, 2021 17:02
@brenthosie brenthosie merged commit dcddd59 into master Mar 9, 2021
@brenthosie brenthosie deleted the DTM-13847-fix-fields-to-settings branch March 9, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants