fix: fetch tenant id from organization if not available then fetch it from IMS client API #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpapani
reviewed
Jul 28, 2025
| } catch (error) { | ||
| log.error('Error loading IMS_ORG_TENANT_ID_MAPPINGS mapping:', error.message); | ||
| } | ||
| if (!name) { |
Collaborator
There was a problem hiding this comment.
please take note to remove these stale secres from Secret Manager after deployment
rpapani
reviewed
Jul 28, 2025
|
This PR will trigger no release when merged. |
rpapani
approved these changes
Jul 29, 2025
Collaborator
rpapani
left a comment
rpapani
left a comment
There was a problem hiding this comment.
looks good.
Build is failing, please check.
rpapani
reviewed
Aug 14, 2025
| // Get tenantId from IMS org details if tenantId is not there in organization | ||
| let imsOrgDetails; | ||
| try { | ||
| imsOrgDetails = await context.imsClient.getImsOrganizationDetails(imsOrgId); |
Collaborator
There was a problem hiding this comment.
const { imsClient } = context;
backup would be
const imsClient = IMSClient.createFrom(context);
rpapani
reviewed
Aug 14, 2025
rpapani
approved these changes
Aug 14, 2025
rpapani
changed the title
solaris007
pushed a commit
that referenced
this pull request
Aug 14, 2025
## [1.1.3](v1.1.2...v1.1.3) (2025-08-14) ### Bug Fixes * fetch tenant id from organization ([#21](#21)) ([dae1bc3](dae1bc3))
Member
|
🎉 This PR is included in version 1.1.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
tkotthakota-adobe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please add IMS_HOST, IMS_CLIENT_ID, IMS_CLIENT_CODE, IMS_CLIENT_SECRET to task-manager secrets in prod and please use ims client
aem-project-collab-serviceas that's the ims client has access to all the tenants, otheriwise, we'll run intoIMS getProductContextsByImsOrgId request failed with status: 400