Skip to content

Commit e28af42

Browse files
lazdGarthDB
authored andcommitted
feat: change all instances of .is-selected to .is-open
BREAKING CHANGE: Use .is-open to indicate the popover is shown, not .is-selected
1 parent ee08255 commit e28af42

4 files changed

Lines changed: 9 additions & 9 deletions

File tree

components/inputgroup/metadata/combobox.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ examples:
5353
<div class="spectrum-Textfield spectrum-InputGroup-textfield">
5454
<input type="text" placeholder="Type here" name="field" value="" class="spectrum-Textfield-input spectrum-InputGroup-input">
5555
</div>
56-
<button class="spectrum-Picker spectrum-InputGroup-button is-selected" tabindex="-1" aria-haspopup="true">
56+
<button class="spectrum-Picker spectrum-InputGroup-button is-open" tabindex="-1" aria-haspopup="true">
5757
<svg class="spectrum-Icon spectrum-UIIcon-ChevronDown100 spectrum-Picker-menuIcon spectrum-InputGroup-icon" focusable="false" aria-hidden="true">
5858
<use xlink:href="#spectrum-css-icon-Chevron100" />
5959
</svg>
@@ -125,7 +125,7 @@ examples:
125125
<div class="spectrum-Textfield spectrum-Textfield--quiet spectrum-InputGroup-textfield">
126126
<input type="text" placeholder="Type here" name="field" value="" class="spectrum-Textfield-input spectrum-InputGroup-input">
127127
</div>
128-
<button class="spectrum-Picker spectrum-Picker--quiet spectrum-InputGroup-button is-selected" tabindex="-1" aria-haspopup="true">
128+
<button class="spectrum-Picker spectrum-Picker--quiet spectrum-InputGroup-button is-open" tabindex="-1" aria-haspopup="true">
129129
<svg class="spectrum-Icon spectrum-UIIcon-ChevronDown100 spectrum-Picker-menuIcon spectrum-InputGroup-icon" focusable="false" aria-hidden="true">
130130
<use xlink:href="#spectrum-css-icon-Chevron100" />
131131
</svg>

components/picker/index.css

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ governing permissions and limitations under the License.
173173
}
174174

175175
&:active,
176-
&.is-selected {
176+
&.is-open {
177177
background-color: var(--spectrum-picker-m-background-color-down);
178178
border-color: var(--spectrum-picker-m-border-color-down);
179179

@@ -208,7 +208,7 @@ governing permissions and limitations under the License.
208208
}
209209

210210
&:active,
211-
&.is-selected {
211+
&.is-open {
212212
border-color: var(--spectrum-picker-m-border-color-error-down);
213213
}
214214

@@ -280,7 +280,7 @@ governing permissions and limitations under the License.
280280
}
281281

282282
&:active,
283-
&.is-selected {
283+
&.is-open {
284284
background-color: var(--spectrum-picker-quiet-m-background-color-down);
285285
border-color: var(--spectrum-picker-quiet-m-border-color-down);
286286

components/searchwithin/metadata/searchwithin.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ examples:
3030
3131
<h4>Open</h4>
3232
<form class="spectrum-SearchWithin" style="margin-bottom: 180px;">
33-
<button type="button" class="spectrum-Picker spectrum-SearchWithin-picker is-open is-selected" aria-haspopup="true">
33+
<button type="button" class="spectrum-Picker spectrum-SearchWithin-picker is-open" aria-haspopup="true">
3434
<span class="spectrum-Picker-label">All</span>
3535
<svg class="spectrum-Icon spectrum-UIIcon-ChevronDown100 spectrum-Picker-menuIcon" focusable="false" aria-hidden="true">
3636
<use xlink:href="#spectrum-css-icon-Chevron100" />

components/tabs/metadata/tabs.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,7 @@ examples:
369369
370370
<h4 style="margin-top: 62px;">Open</h4>
371371
<div class="spectrum-Tabs spectrum-Tabs--horizontal" style="width: 409px">
372-
<button class="spectrum-Picker spectrum-Picker--quiet is-selected" aria-haspopup="true">
372+
<button class="spectrum-Picker spectrum-Picker--quiet is-open" aria-haspopup="true">
373373
<span class="spectrum-Picker-label">Tab 1</span>
374374
<svg class="spectrum-Icon spectrum-UIIcon-ChevronDown100 spectrum-Picker-menuIcon" focusable="false" aria-hidden="true">
375375
<use xlink:href="#spectrum-css-icon-Chevron100" />
@@ -404,7 +404,7 @@ examples:
404404
markup: |
405405
<h4>Closed</h4>
406406
<div class="spectrum-Tabs spectrum-Tabs--horizontal spectrum-Tabs--quiet spectrum-Tabs--compact" style="width: 409px">
407-
<button class="spectrum-Picker spectrum-Picker--quiet is-selected" aria-haspopup="true">
407+
<button class="spectrum-Picker spectrum-Picker--quiet is-open" aria-haspopup="true">
408408
<span class="spectrum-Picker-label">Tab 1</span>
409409
<svg class="spectrum-Icon spectrum-UIIcon-ChevronDown100 spectrum-Picker-menuIcon" focusable="false" aria-hidden="true">
410410
<use xlink:href="#spectrum-css-icon-Chevron100" />
@@ -415,7 +415,7 @@ examples:
415415
416416
<h4 style="margin-top: 62px;">Open</h4>
417417
<div class="spectrum-Tabs spectrum-Tabs--horizontal spectrum-Tabs--quiet spectrum-Tabs--compact" style="width: 409px">
418-
<button class="spectrum-Picker spectrum-Picker--quiet is-open is-selected" aria-haspopup="true">
418+
<button class="spectrum-Picker spectrum-Picker--quiet is-open" aria-haspopup="true">
419419
<span class="spectrum-Picker-label">Tab 1</span>
420420
<svg class="spectrum-Icon spectrum-UIIcon-ChevronDown100 spectrum-Picker-menuIcon" focusable="false" aria-hidden="true">
421421
<use xlink:href="#spectrum-css-icon-Chevron100" />

0 commit comments

Comments
 (0)