Skip to content

Conversation

@BaileyMcKelway
Copy link
Contributor

@BaileyMcKelway BaileyMcKelway commented Mar 17, 2021

This fixes any issue where the tracks for the range slider component were not aligned with other sliders.

Description

Fixes #1005

Removed margin-block from the spectrum-Slider-track class.

How and where has this been tested?

  • How this was tested:
    Tested by building locally and navigating to http://localhost:3000/docs/slider.html#slider. Compared Range Slider track to other Sliders.
  • Browser(s) and OS(s) this was tested with:
    -Chrome 89 - Mac 10.15

Screenshots

Comparing new Range Slider to the Standard Slider
Fix

Test Results
Scrubber

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • This pull request is ready to merge.

@castastrophe
Copy link
Contributor

I suspect PR #1547 will end up superseding this so I've highlighted this PR there to ensure changes address this concern.

@bernhard-adobe
Copy link
Contributor

correct @castastrophe .
my latest push to #1547 0483da1#diff-d430d658923968f4c3594512a47549baec7603fff5a59ad37a154be96d72584cR403 should fix this.

Screen Shot 2023-01-10 at 21 38 47

Maybe we could close this PR.

@bernhard-adobe
Copy link
Contributor

This was an issue not only with the Range Slider but all Slider variants that had issues keeping the handle aligned correctly to the slider track:
Here an updated screenshot for the Range-variant:
Screen Shot 2023-01-10 at 21 41 32

Thank you @BaileyMcKelway for your contribution!

@castastrophe
Copy link
Contributor

@BaileyMcKelway Cannot thank you enough for tackling this work. I'm sorry the timing didn't work out for us to be able to merge your solution but we've made sure to address the issue in our PR to rework the token system. If you want to reach out - I could find out about getting a sticker sent to you as thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Range Slider: track isn't vertically centered

4 participants