Skip to content

fix: slider thumb inner background issue, fixes #1133 #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: slider thumb inner background issue, fixes #1133 #1154

wants to merge 1 commit into from

Conversation

@BaileyMcKelway
Copy link
Contributor

@BaileyMcKelway BaileyMcKelway commented Mar 17, 2021 •
edited
Loading

This fixes any issue where the thumb of a slider is transparent when it should be opaque.

Description

Fixes #1133

Changed background for spectrum-Slider-handle class.

How and where has this been tested?

Screenshots

Ramp
Ticks
Range
Ticks+Label

https://user-images.githubusercontent.com/25776618/111511276-f4c42600-8724-11eb-9385-f1f942ffed53.mov
https://user-images.githubusercontent.com/25776618/111511290-f857ad00-8724-11eb-8b39-4013bfa0cc78.mov

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • This pull request is ready to merge.

@BaileyMcKelway
Copy link
Contributor Author

BaileyMcKelway commented Mar 19, 2021 •
edited
Loading

I'm getting this error from Travis that I can't find a solution for. I noticed some other PRs had the same error though.

Screen Shot 2021-03-19 at 3 50 27 PM

@jianliao
Copy link
Contributor

jianliao commented Mar 19, 2021

I restarted the job.

@castastrophe
Copy link
Contributor

castastrophe commented Jan 3, 2023

I suspect PR #1547 will end up superseding this so I've highlighted this PR there to ensure changes address this concern.

@bernhard-adobe
Copy link
Contributor

bernhard-adobe commented Jan 11, 2023

I suspect PR #1547 will end up superseding this so I've highlighted this PR there to ensure changes address this concern.

@castastrophe I pinged PJ to weight in as we currently don't have this documented in the Tokens package nor the Tokens Design Documentation. (Ramp and Ticks is not in there yet).
Screen Shot 2023-01-11 at 20 52 43
@BaileyMcKelway is correct here, we should ensure in these 2 cases for Ramp and Tick that the Ticks and Slider Ramp is not visible.

I will make the updates to #1547

@bernhard-adobe
Copy link
Contributor

bernhard-adobe commented Jan 11, 2023

For Range, I already took care of this in PR #1547
Screen Shot 2023-01-11 at 21 05 09

bernhard-adobe added a commit that referenced this pull request Jan 11, 2023
@bernhard-adobe
feat: border-width down change (follow up on #1154)
63399f6
bernhard-adobe added a commit that referenced this pull request Jan 11, 2023
@bernhard-adobe
feat: fill color for handle, variant ramp and ticks (from #1154)
9386dbc
@bernhard-adobe
Copy link
Contributor

bernhard-adobe commented Jan 11, 2023 •
edited
Loading

I added this to PR #1547
Screen Shot 2023-01-11 at 23 06 03
Screen Shot 2023-01-11 at 23 05 59

@castastrophe
Copy link
Contributor

castastrophe commented Jan 12, 2023

Closing this PR out so we can address it in our tokens migration work but super appreciate the work done here to help us find a solution.

pfulton pushed a commit that referenced this pull request Feb 6, 2023
@bernhard-adobe @pfulton
feat: border-width down change (follow up on #1154)
6b6efa8
pfulton pushed a commit that referenced this pull request Feb 6, 2023
@bernhard-adobe @pfulton
feat: fill color for handle, variant ramp and ticks (from #1154)
6558098
mlogsdon18 pushed a commit that referenced this pull request Mar 21, 2023
@bernhard-adobe @mlogsdon18
feat: border-width down change (follow up on #1154)
7545319
mlogsdon18 pushed a commit that referenced this pull request Mar 21, 2023
@bernhard-adobe @mlogsdon18
feat: fill color for handle, variant ramp and ticks (from #1154)
6b09d80
castastrophe pushed a commit that referenced this pull request Mar 27, 2023
@bernhard-adobe @castastrophe
feat: border-width down change (follow up on #1154)
0c766c3
castastrophe pushed a commit that referenced this pull request Mar 27, 2023
@bernhard-adobe @castastrophe
feat: fill color for handle, variant ramp and ticks (from #1154)
b3bc5ed
castastrophe pushed a commit that referenced this pull request Mar 27, 2023
@bernhard-adobe @castastrophe
feat: border-width down change (follow up on #1154)
7e8b52a
castastrophe pushed a commit that referenced this pull request Mar 27, 2023
@bernhard-adobe @castastrophe
feat: fill color for handle, variant ramp and ticks (from #1154)
a6e6072
mlogsdon18 pushed a commit that referenced this pull request Mar 28, 2023
@bernhard-adobe @mlogsdon18
feat: border-width down change (follow up on #1154)
ec2d350
mlogsdon18 pushed a commit that referenced this pull request Mar 28, 2023
@bernhard-adobe @mlogsdon18
feat: fill color for handle, variant ramp and ticks (from #1154)
c682376
mlogsdon18 pushed a commit that referenced this pull request Mar 29, 2023
@bernhard-adobe @mlogsdon18
feat: border-width down change (follow up on #1154)
093e0c5
mlogsdon18 pushed a commit that referenced this pull request Mar 29, 2023
@bernhard-adobe @mlogsdon18
feat: fill color for handle, variant ramp and ticks (from #1154)
1a321e8
mlogsdon18 pushed a commit that referenced this pull request Mar 29, 2023
@bernhard-adobe @mlogsdon18
feat: border-width down change (follow up on #1154)
429e2fc
mlogsdon18 pushed a commit that referenced this pull request Mar 29, 2023
@bernhard-adobe @mlogsdon18
feat: fill color for handle, variant ramp and ticks (from #1154)
f524d93
mlogsdon18 pushed a commit that referenced this pull request Mar 31, 2023
@bernhard-adobe @mlogsdon18
feat: border-width down change (follow up on #1154)
78ba382
mlogsdon18 pushed a commit that referenced this pull request Mar 31, 2023
@bernhard-adobe @mlogsdon18
feat: fill color for handle, variant ramp and ticks (from #1154)
48d9c47
mlogsdon18 pushed a commit that referenced this pull request Apr 20, 2023
@bernhard-adobe @mlogsdon18
feat: border-width down change (follow up on #1154)
7b497ff
mlogsdon18 pushed a commit that referenced this pull request Apr 20, 2023
@bernhard-adobe @mlogsdon18
feat: fill color for handle, variant ramp and ticks (from #1154)
9a6bd66
mlogsdon18 pushed a commit that referenced this pull request Apr 21, 2023
@bernhard-adobe @mlogsdon18
feat: border-width down change (follow up on #1154)
d714993
mlogsdon18 pushed a commit that referenced this pull request Apr 21, 2023
@bernhard-adobe @mlogsdon18
feat: fill color for handle, variant ramp and ticks (from #1154)
b169d76
mlogsdon18 pushed a commit that referenced this pull request May 1, 2023
@bernhard-adobe @mlogsdon18
feat: border-width down change (follow up on #1154)
cd447bc
mlogsdon18 pushed a commit that referenced this pull request May 1, 2023
@bernhard-adobe @mlogsdon18
feat: fill color for handle, variant ramp and ticks (from #1154)
bc28ccf
mlogsdon18 pushed a commit that referenced this pull request May 4, 2023
@bernhard-adobe @mlogsdon18
feat: border-width down change (follow up on #1154)
0f5bfcc
mlogsdon18 pushed a commit that referenced this pull request May 4, 2023
@bernhard-adobe @mlogsdon18
feat: fill color for handle, variant ramp and ticks (from #1154)
273fcfa
mlogsdon18 pushed a commit that referenced this pull request May 8, 2023
@bernhard-adobe @mlogsdon18
feat: border-width down change (follow up on #1154)
e566892
mlogsdon18 pushed a commit that referenced this pull request May 8, 2023
@bernhard-adobe @mlogsdon18
feat: fill color for handle, variant ramp and ticks (from #1154)
93c967b
mlogsdon18 pushed a commit that referenced this pull request May 8, 2023
@bernhard-adobe @mlogsdon18
feat: border-width down change (follow up on #1154)
5f015dc
mlogsdon18 pushed a commit that referenced this pull request May 8, 2023
@bernhard-adobe @mlogsdon18
feat: fill color for handle, variant ramp and ticks (from #1154)
fb789a8
mlogsdon18 pushed a commit that referenced this pull request May 16, 2023
@bernhard-adobe @mlogsdon18
feat: border-width down change (follow up on #1154)
d8c343e
mlogsdon18 pushed a commit that referenced this pull request May 16, 2023
@bernhard-adobe @mlogsdon18
feat: fill color for handle, variant ramp and ticks (from #1154)
dc027ef
mlogsdon18 pushed a commit that referenced this pull request May 17, 2023
@bernhard-adobe @mlogsdon18
feat: border-width down change (follow up on #1154)
bd4ab22
mlogsdon18 pushed a commit that referenced this pull request May 17, 2023
@bernhard-adobe @mlogsdon18
feat: fill color for handle, variant ramp and ticks (from #1154)
23b3a22
mlogsdon18 pushed a commit that referenced this pull request May 18, 2023
@bernhard-adobe @mlogsdon18
feat: border-width down change (follow up on #1154)
407ae9b
mlogsdon18 pushed a commit that referenced this pull request May 18, 2023
@bernhard-adobe @mlogsdon18
feat: fill color for handle, variant ramp and ticks (from #1154)
8f177ad
mlogsdon18 pushed a commit that referenced this pull request May 18, 2023
@bernhard-adobe @mlogsdon18
feat: border-width down change (follow up on #1154)
d72038a
mlogsdon18 pushed a commit that referenced this pull request May 18, 2023
@bernhard-adobe @mlogsdon18
feat: fill color for handle, variant ramp and ticks (from #1154)
712f830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Slider thumb inner background should not be transparent

5 participants

@BaileyMcKelway @jianliao @castastrophe @bernhard-adobe @pfulton