Skip to content

Conversation

@Westbrook
Copy link
Contributor

Description

Correct margin-block-start in Range variant of Slider component.

fixes #1205

How and where has this been tested?

  • How this was tested: Visually inspecting the local build of the documentation site
  • Browser(s) and OS(s) this was tested with: Stable Chrome on Catalina

Screenshots

Before:
image
After:
image

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • This pull request is ready to merge.

@Westbrook Westbrook requested a review from GarthDB June 11, 2021 10:10
@adobe-spectrum-bot
Copy link
Collaborator

VRT successfully! 🎊

View the VRT result

@castastrophe
Copy link
Contributor

I suspect PR #1547 will end up superseding this so I've highlighted this PR there to ensure changes address this concern.

@bernhard-adobe
Copy link
Contributor

I suspect PR #1547 will end up superseding this so I've highlighted this PR there to ensure changes address this concern.

yes @castastrophe. This is part of #1547 where the padding has been corrected for Range and regular Slider variant.

@castastrophe
Copy link
Contributor

Awesome, thanks @bernhard-adobe for confirming and thank you @Westbrook for the contribution! Closing this out in favor of the rewrite work.

@castastrophe castastrophe deleted the westbrook/range-slider branch March 7, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Slider] Range slider track is given wrong "margin-block-start"

6 participants