-
Notifications
You must be signed in to change notification settings - Fork 207
feat(slider)!: migrating tokens #1547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
d436bc3
feat(slider!): slider core tokens (CSS-177)
mlogsdon18 0d6ba90
chore(slider): manual version bump for beta release
pfulton d04cbec
feat: pr feedback around soft-coding
bernhard-adobe 0150cf9
feat: setting border radii an var correction
bernhard-adobe b70587b
feat: upping core vars to 5.0.0
bernhard-adobe 4ad3949
feat: core-tokens 5.0.0 line-height fix
bernhard-adobe c5cd126
feat: addressing PR feedback
bernhard-adobe 35960c9
feat: adjusting high contrast mode colors
bernhard-adobe 9dd3b19
feat: rounding corners
bernhard-adobe 467d01a
feat: high contrast slider tick
bernhard-adobe 33fcc67
feat: minor test removal
bernhard-adobe 80e5c93
feat: border rings for slider
bernhard-adobe f82fc6a
feat: correct border token for down + ramp high contrast color
bernhard-adobe 4598f5f
feat: make tick slider handles align to ticks (follow up on #1289)
bernhard-adobe 8d4ddb4
feat: slider tick position
bernhard-adobe 093e0c5
feat: border-width down change (follow up on #1154)
bernhard-adobe 1a321e8
feat: fill color for handle, variant ramp and ticks (from #1154)
bernhard-adobe c8410f6
feat: border-width adjustment for handle-down
bernhard-adobe 4bb2b81
feat: removing commented out width calculations
bernhard-adobe 05e271c
feat: widths, top, height in sizes and starts
bernhard-adobe 12fe7fc
feat: sizing widths and heights, including animations
bernhard-adobe eadc91c
feat: remove double-mods and contrast mods
bernhard-adobe fe5b0e7
feat: use t-shirt sized handle size, move ramp forced colors bottom, …
bernhard-adobe 5d86946
feat: high contrast feedback
bernhard-adobe 6009b95
feat: custom vars for ticks
bernhard-adobe dd8b6ed
feat: t-shirt size default
bernhard-adobe b3ecbac
feat: correct 32px height
bernhard-adobe da4d4ac
feat: high-contrast mode simplifications
bernhard-adobe 99d2a75
feat: slider control height now 16px
bernhard-adobe 6832d1d
feat: adding margin to the bottom of handle
bernhard-adobe 9028ffe
feat: more control spacing for tick-variant
bernhard-adobe 15e2d83
feat: cjk rename
bernhard-adobe cc0ff5c
feat: updated label margin
bernhard-adobe c260f78
feat: slider label block-end margins via design update
bernhard-adobe 7255a46
feat: 80px removal
bernhard-adobe 11f4b99
feat: disabled tick-mark colors use disabled background-color token.
bernhard-adobe 55696eb
feat: setting slider tick marks and label
bernhard-adobe 8529c61
fix(slider): disabled tick label color
lunarfusion a6155a7
fix(slider): refactor without :has
lunarfusion 5daf116
chore(slider): use latest tokens dependency
pfulton eb37727
chore(slider): manual version bump for beta release
pfulton 3f544c0
fix(slider): resolve malformed CSS
pfulton f16b838
fix(slider): resolve malformed syntax
pfulton 7a54cda
style(slider): add cursor pointer
mlogsdon18 4e90e30
chore(slider): remove unneeded classes and add headings to docs
mlogsdon18 3e9f549
feat: update tokens package and added new tokens for bottom-to-text
mlogsdon18 1b38974
refactor(slider): adding in updated tokens and label sizing to docs
mlogsdon18 22f22d8
feat(slider): add gradient story
mlogsdon18 d0f00a0
docs(slider): added range variant instructions for three handles
mlogsdon18 4df58ae
chore(slider): add todos for tokens still needed
mlogsdon18 96521a4
chore(slider): manual prerelease bump
castastrophe e1460a5
fix(slider): remove unneeded css
mlogsdon18 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| module.exports = require('@spectrum-css/component-builder'); | ||
| module.exports = require('@spectrum-css/component-builder-simple'); |
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -159,3 +159,12 @@ Disabled.args = { | |
| ...Default.args, | ||
| isDisabled: true, | ||
| }; | ||
|
|
||
| export const Gradient = Template.bind({}); | ||
| Gradient.args = { | ||
| ...Default.args, | ||
| style: { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will need to be added to the argTypes above to hide it from the args table below. |
||
| "--spectrum-slider-track-color": "linear-gradient(to right, red, green 100%)", | ||
| "--spectrum-slider-track-color-rtl": "linear-gradient(to left, red, green 100%)" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| /* | ||
| Copyright 2023 Adobe. All rights reserved. | ||
| This file is licensed to you under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. You may obtain a copy | ||
| of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software distributed under | ||
| the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS | ||
| OF ANY KIND, either express or implied. See the License for the specific language | ||
| governing permissions and limitations under the License. | ||
| */ | ||
|
|
||
| @container (--system: express) { | ||
| .spectrum-Slider { | ||
|
|
||
| --spectrum-slider-margin-top-offset: -6px; | ||
| --spectrum-slider-track-color: var(--spectrum-gray-200); | ||
| --spectrum-slider-track-fill-color: var(--spectrum-gray-600); | ||
| --spectrum-slider-ramp-track-color: var(--spectrum-gray-300); | ||
| --spectrum-slider-ramp-track-color-disabled: var(--spectrum-gray-200); | ||
|
|
||
| --spectrum-slider-handle-background-color: var(--spectrum-gray-50); | ||
| --spectrum-slider-handle-background-color-disabled: var(--spectrum-gray-50); | ||
| --spectrum-slider-ramp-handle-background-color: var(--spectrum-gray-50); | ||
| --spectrum-slider-ticks-handle-background-color: var(--spectrum-gray-50); | ||
| --spectrum-slider-handle-border-color: var(--spectrum-gray-800); | ||
| --spectrum-slider-handle-disabled-background-color: var(--spectrum-gray-50); | ||
|
|
||
| --spectrum-slider-tick-mark-color: var(--spectrum-gray-200); | ||
|
|
||
| --spectrum-slider-handle-border-color-hover: var(--spectrum-gray-900); | ||
| --spectrum-slider-handle-border-color-down: var(--spectrum-gray-900); | ||
| --spectrum-slider-handle-border-color-key-focus: var(--spectrum-gray-900); | ||
| --spectrum-slider-handle-focus-ring-color-key-focus: var(--spectrum-focus-indicator-color); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /* | ||
| Copyright 2023 Adobe. All rights reserved. | ||
| This file is licensed to you under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. You may obtain a copy | ||
| of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software distributed under | ||
| the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS | ||
| OF ANY KIND, either express or implied. See the License for the specific language | ||
| governing permissions and limitations under the License. | ||
| */ | ||
|
|
||
| @container (--system: spectrum) { | ||
| .spectrum-Slider { | ||
|
|
||
|
|
||
| --spectrum-slider-margin-top-offset: 0px; | ||
|
|
||
| --spectrum-slider-track-color: var(--spectrum-gray-300); | ||
| --spectrum-slider-track-fill-color: var(--spectrum-gray-700); | ||
| --spectrum-slider-ramp-track-color: var(--spectrum-gray-400); | ||
| --spectrum-slider-ramp-track-color-disabled: var(--spectrum-gray-200); | ||
|
|
||
| --spectrum-slider-handle-background-color: transparent; | ||
| --spectrum-slider-handle-background-color-disabled: transparent; | ||
| --spectrum-slider-ramp-handle-background-color: var(--spectrum-gray-100); | ||
| --spectrum-slider-ticks-handle-background-color: var(--spectrum-gray-100); | ||
| --spectrum-slider-handle-border-color: var(--spectrum-gray-700); | ||
| --spectrum-slider-handle-disabled-background-color: var(--spectrum-gray-100); | ||
|
|
||
| --spectrum-slider-tick-mark-color: var(--spectrum-gray-300); | ||
|
|
||
| --spectrum-slider-handle-border-color-hover: var(--spectrum-gray-800); | ||
| --spectrum-slider-handle-border-color-down: var(--spectrum-gray-800); | ||
| --spectrum-slider-handle-border-color-key-focus: var(--spectrum-gray-800); | ||
| --spectrum-slider-handle-focus-ring-color-key-focus: var(--spectrum-focus-indicator-color); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As much as possible I'd like to keep peerDependencies at their lowest compatible release.