Skip to content

Conversation

@mlogsdon18
Copy link
Contributor

This is a new PR based on this PR that was closed: #1547

It was closed because the user who opened it bschmidt, had not signed the Adobe CLA and therefore we could not merge the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2023

🚀 Deployed on https://pr-1696--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request March 29, 2023 17:04 Inactive
@pfulton pfulton self-requested a review March 29, 2023 17:57
@mlogsdon18 mlogsdon18 force-pushed the css-177-slider-tokens branch from e17f9a2 to 4f0bec1 Compare March 29, 2023 18:44
@github-actions github-actions bot temporarily deployed to pull request March 29, 2023 18:49 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 30, 2023 20:26 Inactive
@mlogsdon18 mlogsdon18 force-pushed the css-177-slider-tokens branch from f4cceb8 to 804ccba Compare March 31, 2023 17:47
@github-actions github-actions bot temporarily deployed to pull request March 31, 2023 17:54 Inactive
@pfulton
Copy link
Collaborator

pfulton commented Mar 31, 2023

New beta released:
@spectrum-css/slider@4.0.0-beta.6

@github-actions github-actions bot temporarily deployed to pull request March 31, 2023 18:08 Inactive
@pfulton pfulton added breaking change Results in a breaking API change released-beta labels Apr 5, 2023
@mlogsdon18 mlogsdon18 added the blocked See description and comments for what is blocking this issue label Apr 11, 2023
@mlogsdon18 mlogsdon18 force-pushed the css-177-slider-tokens branch from ba2d4d5 to ef853e0 Compare April 20, 2023 18:23
@github-actions github-actions bot temporarily deployed to pull request April 20, 2023 18:31 Inactive
@mlogsdon18 mlogsdon18 force-pushed the css-177-slider-tokens branch from 6b2a735 to f5a9921 Compare April 21, 2023 18:10
@github-actions github-actions bot temporarily deployed to pull request April 21, 2023 20:19 Inactive
@mlogsdon18 mlogsdon18 force-pushed the css-177-slider-tokens branch from 8505348 to e8d475c Compare May 1, 2023 13:12
@github-actions github-actions bot temporarily deployed to pull request May 1, 2023 13:21 Inactive
@mlogsdon18 mlogsdon18 force-pushed the css-177-slider-tokens branch from ca7bf31 to 3fab034 Compare May 4, 2023 17:13
@github-actions github-actions bot temporarily deployed to pull request May 4, 2023 17:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 4, 2023 17:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 5, 2023 13:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 5, 2023 16:00 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 8, 2023 13:13 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 8, 2023 13:36 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 8, 2023 18:52 Inactive
mlogsdon18 and others added 24 commits May 18, 2023 15:24
update slider story to use fieldlabel
update fieldlabel story to accept id and forInput
remove margin between label and control
- update calculation for slider handle and track positioning
@mlogsdon18 mlogsdon18 force-pushed the css-177-slider-tokens branch from d94ce53 to 0c15aa3 Compare May 18, 2023 19:24
@github-actions github-actions bot temporarily deployed to pull request May 18, 2023 19:34 Inactive
@pfulton pfulton enabled auto-merge (squash) May 18, 2023 19:41
@pfulton pfulton disabled auto-merge May 18, 2023 19:41
@pfulton pfulton merged commit 37724f1 into main May 18, 2023
@pfulton pfulton deleted the css-177-slider-tokens branch May 18, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Results in a breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants