Skip to content

Conversation

@jenndiaz
Copy link
Contributor

@jenndiaz jenndiaz commented Dec 5, 2023

Description

Removed all examples of invalid tags with out the correct icon from the docs site and storybook.
Updated storybook controls so invalid tags always have the alert icon.

Design Docs

Addresses SWC issue 3378

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

@mdt2

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

🚀 Deployed on https://pr-2341--spectrum-css.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

File metrics

Summary

Total size: 3.61 MB*

🎉 No changes detected in any packages

* An ASCII character in UTF-8 is 8 bits or 1 byte.

@jenndiaz jenndiaz requested review from jawinn, mdt2 and pfulton December 5, 2023 20:31
Copy link
Collaborator

@mdt2 mdt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Collaborator

@pfulton pfulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pfulton pfulton changed the title fix(tag): invalid tags should always include icon docs(tag): invalid tags should always include icon Dec 6, 2023
@pfulton pfulton force-pushed the jenndiaz/css-646-tag-invalid-fix branch from 153bdfd to d9d6170 Compare December 6, 2023 19:12
@pfulton pfulton added the run_vrt For use on PRs looking to kick off VRT label Dec 6, 2023
@pfulton pfulton merged commit c6fa9e5 into main Dec 6, 2023
@pfulton pfulton deleted the jenndiaz/css-646-tag-invalid-fix branch December 6, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge run_vrt For use on PRs looking to kick off VRT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants