Skip to content

Conversation

@castastrophe
Copy link
Contributor

@castastrophe castastrophe commented Dec 6, 2023

Description

A small patch to the details table formatting in the CI diff output comment and a clarification of values with less than 0.01KB difference.

You can see these issues in the screenshots below from #2338 (comment)

Screenshot 2023-12-06 at 12 16 28 PM Screenshot 2023-12-06 at 12 16 35 PM

How and where has this been tested?

Should see these fixes in the comments of this PR.

To-do list

@castastrophe castastrophe requested a review from mdt2 December 6, 2023 17:17
@castastrophe castastrophe self-assigned this Dec 6, 2023
@castastrophe castastrophe added size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. build Issues associated with the build process; often a refactor ready-for-review labels Dec 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

🚀 Deployed on https://pr-2345--spectrum-css.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

File metrics

Summary

Total size: 3.61 MB*

🎉 No changes detected in any packages

* An ASCII character in UTF-8 is 8 bits or 1 byte.

Copy link
Collaborator

@mdt2 mdt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@castastrophe castastrophe force-pushed the chore-ci-diff-data-output branch from c8f6cf8 to 92f1414 Compare December 6, 2023 18:58
@castastrophe castastrophe added the skip_vrt Add to a PR to skip running VRT (but still pass the action) label Dec 6, 2023
@castastrophe castastrophe force-pushed the chore-ci-diff-data-output branch from 92f1414 to 0e5de05 Compare December 6, 2023 19:38
@castastrophe castastrophe enabled auto-merge (squash) December 6, 2023 19:38
@castastrophe castastrophe merged commit 5243123 into main Dec 6, 2023
@castastrophe castastrophe deleted the chore-ci-diff-data-output branch December 6, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues associated with the build process; often a refactor ready-for-review size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. skip_vrt Add to a PR to skip running VRT (but still pass the action)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants