Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
d3e9355
feat: adding t-shirt sizes typography (SDS-2513)
bernhard-adobe Nov 15, 2019
71354df
fix: feedback from Nate (SDS-2513)
bernhard-adobe Nov 25, 2019
e5d4c90
fix: addressing font-family feedback (SDS-2513)
bernhard-adobe Dec 3, 2019
df1e747
fix: adding em to code (SDS-2513)
bernhard-adobe Dec 5, 2019
faa6227
fix: split typography & international updates (SDS-2513)
bernhard-adobe Dec 13, 2019
77a054b
fix: removing background testing colors and temp files (SDS-2513)
bernhard-adobe Dec 13, 2019
4be7e19
fix: changing naming convention (SDS-2513)
bernhard-adobe Dec 16, 2019
c971901
fix: updating documentation for typography classnames (SDS-2513)
bernhard-adobe Dec 16, 2019
6a217ea
fix: removing log-colors and fixing docs (SDS-2513)
bernhard-adobe Dec 16, 2019
ac758fc
fix: removing temp typography page (SDS-2513)
bernhard-adobe Dec 16, 2019
191a010
docs: removing line seperators (SDS-2513)
bernhard-adobe Dec 16, 2019
6657a4b
feat: adding SUIT rules (SDS-2513)
bernhard-adobe Dec 17, 2019
190243a
fix: removing more selectors (SDS-2513)
bernhard-adobe Dec 19, 2019
06ab81f
fix: suggested simplifications for em, strong children (SDS-2513)
bernhard-adobe Jan 7, 2020
6ee1adb
fix: temp swapping out of typekit
bernhard-adobe Jan 9, 2020
3813c60
fix: swapping out the Typekit Ids
bernhard-adobe Jan 10, 2020
b066e60
fix: updating international page
bernhard-adobe Jan 10, 2020
1ce21d2
fix: typo on international page
bernhard-adobe Jan 10, 2020
7b8f9c6
fix: typekit changes
bernhard-adobe Jan 10, 2020
1bb1efe
fix: fixing dropzone typeface
bernhard-adobe Jan 10, 2020
12c235a
fix: updating correct weights
bernhard-adobe Jan 11, 2020
42b0b5a
fix: updating 404 heading
bernhard-adobe Jan 11, 2020
56acd4b
docs: fix status and spelling errors
lazd Feb 6, 2020
f871b74
Typography metadata fixes and deprecation bits (#523)
lazd Feb 7, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ When this file is imported, if in updated version of `@spectrum-css/vars` change

In most cases, this file will not be required, so you can safely ignore it. If you see unexpected visual changes creeping into components that you have not updated, `dist/vars.css` may correct them.


## Contributing

Check out the [contributing guidelines](.github/CONTRIBUTING.md) for quick start information, and head over to the [component documentation](components/README.md) and [bundle documentation](bundles/README.md) for more information.
Expand Down Expand Up @@ -222,6 +223,8 @@ The following tasks are available:
- `gulp packageLint` - Lint the `package.json` file for each component in the monorepo
- `gulp readmeLint` - Generate a generic `README.md` file for each component in the monorepo



## Testing

Visual regression testing is implemented by [BackstopJS](https://github.com/garris/BackstopJS). In order to avoid browser rendering inconsistent issue on different environments, the test needs to run inside of docker container.
Expand Down Expand Up @@ -256,6 +259,9 @@ Both `backstop:test` and `backstop:docker:test` accept arguments to customize yo
- `npm run backstop:docker:test themes=lightest,light scales=medium,large radio` - Run test for `radio` and its dependents components with color stop as `lightest` and `light` and scale as `medium` and `large`. It means that a single scenario will run 4 times.
- `npm run backstop:docker:test themes=lightest,light,dark,darkest scales=medium,large` - Run test for all the components with all the color and scale combinations. It means that a single scenario will be run 8 times.

___
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add these horizontal rules, please remove them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it would increase readability in this rather large documentation by adding structure. I will remove it.



## Releasing

### Releasing individual components
Expand Down
1 change: 1 addition & 0 deletions components/button/metadata/actionbutton.yml
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ examples:
</button>
- id: actionbutton-quiet
name: Quiet
description: The Quiet Action Button should be used where you previously used the [deprecated Tool component](tool.html).
markup: |
<button class="spectrum-ActionButton spectrum-ActionButton--quiet">
<svg class="spectrum-Icon spectrum-Icon--sizeS" focusable="false" aria-hidden="true" aria-label="Edit">
Expand Down
3 changes: 2 additions & 1 deletion components/button/metadata/tool.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
name: Tool
status: Verified
dnaStatus: Deprecated
description: The tool button.
SpectrumSiteSlug: https://spectrum.adobe.com/page/tool/
hide: true
examples:
- name: Standard
markup: |
Expand Down
2 changes: 1 addition & 1 deletion components/buttongroup/metadata/buttongroup.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Button Group
SpectrumSiteSlug: https://spectrum.corp.adobe.com/page/button/
SpectrumSiteSlug: https://spectrum.adobe.com/page/button/
examples:
- id: buttongroup
name: Horizontal
Expand Down
18 changes: 9 additions & 9 deletions components/commons/fonts.css
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,15 @@ governing permissions and limitations under the License.
--spectrum-font-family-condensed: adobe-clean-condensed, var(--spectrum-font-family-base);
*/

--spectrum-font-family-base: 'adobe-clean-ux', 'adobe-clean', 'Source Sans Pro', var(--spectrum-font-fallbacks-sans);
--spectrum-font-family-han: 'adobe-clean-han-japanese', var(--spectrum-font-fallbacks-sans);
--spectrum-font-family-ar: 'adobe-arabic', 'myriad-arabic', var(--spectrum-font-fallbacks-sans);
--spectrum-font-family-he: 'adobe-hebrew', var(--spectrum-font-fallbacks-sans);
--spectrum-font-family-zhhans: 'adobe-clean-han-simplified-c', 'SimSun', 'Heiti SC Light', var(--spectrum-font-fallbacks-sans);
--spectrum-font-family-zh: var(--spectrum-font-family-zhhans);
--spectrum-font-family-zhhant: 'adobe-clean-han-traditional', 'Microsoft JhengHei UI', 'Microsoft JhengHei', 'Heiti TC Light', var(--spectrum-font-fallbacks-sans);
--spectrum-font-family-ko: 'adobe-clean-han-korean', 'Malgun Gothic', 'Apple Gothic', var(--spectrum-font-fallbacks-sans);
--spectrum-font-family-ja: 'adobe-clean-han-japanese', 'Yu Gothic', '\30E1 \30A4 \30EA \30AA', '\30D2 \30E9 \30AE \30CE \89D2 \30B4 Pro W3', 'Hiragino Kaku Gothic Pro W3', 'Osaka', '\FF2D \FF33 \FF30 \30B4 \30B7 \30C3 \30AF', 'MS PGothic', var(--spectrum-font-fallbacks-sans);
--spectrum-font-family-base: var(--spectrum-alias-body-text-font-family);
--spectrum-font-family-ar: var(--spectrum-alias-font-family-ar);
--spectrum-font-family-he: var(--spectrum-alias-font-family-he);
--spectrum-font-family-zh: var(--spectrum-alias-font-family-zh);
--spectrum-font-family-zhhans: var(--spectrum-alias-font-family-zhhans);
--spectrum-font-family-ko: var(--spectrum-alias-font-family-ko);
--spectrum-font-family-ja: var(--spectrum-alias-font-family-ja);
--spectrum-font-family-han: var(--spectrum-alias-font-family-zh);
--spectrum-font-family-zhhant: var(--spectrum-alias-font-family-zh);
--spectrum-text-size: var(--spectrum-alias-font-size-default);
--spectrum-text-body-line-height: var(--spectrum-alias-line-height-medium);
--spectrum-text-size-text-label: var(--spectrum-label-text-size);
Expand Down
4 changes: 2 additions & 2 deletions components/dropzone/metadata/dropzone.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ examples:
<div class="spectrum-Dropzone" role="region" tabindex="0" style="width: 300px;">
<div class="spectrum-IllustratedMessage spectrum-IllustratedMessage--cta">
<svg class="spectrum-IllustratedMessage-illustration" width="199" height="98" viewBox="0 0 199 97.7"><defs><style>.cls-1,.cls-2{fill:none;stroke-linecap:round;stroke-linejoin:round;}.cls-1{stroke-width:3px;}.cls-2{stroke-width:2px;}</style></defs><path class="cls-1" d="M110.53,85.66,100.26,95.89a1.09,1.09,0,0,1-1.52,0L88.47,85.66"/><line class="cls-1" x1="99.5" y1="95.5" x2="99.5" y2="58.5"/><path class="cls-1" d="M105.5,73.5h19a2,2,0,0,0,2-2v-43"/><path class="cls-1" d="M126.5,22.5h-19a2,2,0,0,1-2-2V1.5h-31a2,2,0,0,0-2,2v68a2,2,0,0,0,2,2h19"/><line class="cls-1" x1="105.5" y1="1.5" x2="126.5" y2="22.5"/><path class="cls-2" d="M47.93,50.49a5,5,0,1,0-4.83-5A4.93,4.93,0,0,0,47.93,50.49Z"/><path class="cls-2" d="M36.6,65.93,42.05,60A2.06,2.06,0,0,1,45,60l12.68,13.2"/><path class="cls-2" d="M3.14,73.23,22.42,53.76a1.65,1.65,0,0,1,2.38,0l19.05,19.7"/><path class="cls-1" d="M139.5,36.5H196A1.49,1.49,0,0,1,197.5,38V72A1.49,1.49,0,0,1,196,73.5H141A1.49,1.49,0,0,1,139.5,72V32A1.49,1.49,0,0,1,141,30.5H154a2.43,2.43,0,0,1,1.67.66l6,5.66"/><rect class="cls-1" x="1.5" y="34.5" width="58" height="39" rx="2" ry="2"/></svg>
<h2 class="spectrum-Heading spectrum-Heading--pageTitle spectrum-IllustratedMessage-heading">Drag and Drop Your File</h2>
<h2 class="spectrum-Heading--pageTitle spectrum-IllustratedMessage-heading">Drag and Drop Your File</h2>
<p class="spectrum-Body--secondary spectrum-IllustratedMessage-description"><a href="#" class="spectrum-Link">Select a File</a> from your computer<br> or <a href="#" class="spectrum-Link">Search Adobe Stock</a></p>
</div>
</div>
Expand All @@ -17,7 +17,7 @@ examples:
<div class="spectrum-Dropzone is-dragged" role="region" tabindex="0" style="width: 300px;">
<div class="spectrum-IllustratedMessage spectrum-IllustratedMessage--cta">
<svg class="spectrum-IllustratedMessage-illustration" width="199" height="98" viewBox="0 0 199 97.7"><defs><style>.cls-1,.cls-2{fill:none;stroke-linecap:round;stroke-linejoin:round;}.cls-1{stroke-width:3px;}.cls-2{stroke-width:2px;}</style></defs><path class="cls-1" d="M110.53,85.66,100.26,95.89a1.09,1.09,0,0,1-1.52,0L88.47,85.66"/><line class="cls-1" x1="99.5" y1="95.5" x2="99.5" y2="58.5"/><path class="cls-1" d="M105.5,73.5h19a2,2,0,0,0,2-2v-43"/><path class="cls-1" d="M126.5,22.5h-19a2,2,0,0,1-2-2V1.5h-31a2,2,0,0,0-2,2v68a2,2,0,0,0,2,2h19"/><line class="cls-1" x1="105.5" y1="1.5" x2="126.5" y2="22.5"/><path class="cls-2" d="M47.93,50.49a5,5,0,1,0-4.83-5A4.93,4.93,0,0,0,47.93,50.49Z"/><path class="cls-2" d="M36.6,65.93,42.05,60A2.06,2.06,0,0,1,45,60l12.68,13.2"/><path class="cls-2" d="M3.14,73.23,22.42,53.76a1.65,1.65,0,0,1,2.38,0l19.05,19.7"/><path class="cls-1" d="M139.5,36.5H196A1.49,1.49,0,0,1,197.5,38V72A1.49,1.49,0,0,1,196,73.5H141A1.49,1.49,0,0,1,139.5,72V32A1.49,1.49,0,0,1,141,30.5H154a2.43,2.43,0,0,1,1.67.66l6,5.66"/><rect class="cls-1" x="1.5" y="34.5" width="58" height="39" rx="2" ry="2"/></svg>
<h2 class="spectrum-Heading spectrum-Heading--pageTitle spectrum-IllustratedMessage-heading">Drag and Drop Your File</h2>
<h2 class="spectrum-Heading--pageTitle spectrum-IllustratedMessage-heading">Drag and Drop Your File</h2>
<p class="spectrum-Body--secondary spectrum-IllustratedMessage-description"><a href="#" class="spectrum-Link">Select a File</a> from your computer<br> or <a href="#" class="spectrum-Link">Search Adobe Stock</a></p>
</div>
</div>
4 changes: 2 additions & 2 deletions components/illustratedmessage/metadata/illustratedmessage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ examples:
markup: |
<div class="spectrum-IllustratedMessage">
<svg class="spectrum-IllustratedMessage-illustration" xmlns="http://www.w3.org/2000/svg" width="200" height="98" viewBox="0 0 199 97.7"><defs><style>.cls-1,.cls-2{fill:none;stroke-linecap:round;stroke-linejoin:round;}.cls-1{stroke-width:3px;}.cls-2{stroke-width:2px;}</style></defs><title>Asset 1</title><g id="Layer_2" data-name="Layer 2"><g id="illustrations"><path class="cls-1" d="M110.53,85.66,100.26,95.89a1.09,1.09,0,0,1-1.52,0L88.47,85.66"/><line class="cls-1" x1="99.5" y1="95.5" x2="99.5" y2="58.5"/><path class="cls-1" d="M105.5,73.5h19a2,2,0,0,0,2-2v-43"/><path class="cls-1" d="M126.5,22.5h-19a2,2,0,0,1-2-2V1.5h-31a2,2,0,0,0-2,2v68a2,2,0,0,0,2,2h19"/><line class="cls-1" x1="105.5" y1="1.5" x2="126.5" y2="22.5"/><path class="cls-2" d="M47.93,50.49a5,5,0,1,0-4.83-5A4.93,4.93,0,0,0,47.93,50.49Z"/><path class="cls-2" d="M36.6,65.93,42.05,60A2.06,2.06,0,0,1,45,60l12.68,13.2"/><path class="cls-2" d="M3.14,73.23,22.42,53.76a1.65,1.65,0,0,1,2.38,0l19.05,19.7"/><path class="cls-1" d="M139.5,36.5H196A1.49,1.49,0,0,1,197.5,38V72A1.49,1.49,0,0,1,196,73.5H141A1.49,1.49,0,0,1,139.5,72V32A1.49,1.49,0,0,1,141,30.5H154a2.43,2.43,0,0,1,1.67.66l6,5.66"/><rect class="cls-1" x="1.5" y="34.5" width="58" height="39" rx="2" ry="2"/></g></g></svg>
<h2 class="spectrum-Heading spectrum-Heading--pageTitle spectrum-IllustratedMessage-heading">Error 404: Page Not Found</h2>
<h2 class="spectrum-Heading--pageTitle spectrum-IllustratedMessage-heading">Error 404: Page Not Found</h2>
<p class="spectrum-Body--secondary spectrum-IllustratedMessage-description">This page isn't available. Try checking the URL or visit a different page.</p>
</div>
- id: illustratedmessage-default
Expand All @@ -16,6 +16,6 @@ examples:
markup: |
<div class="spectrum-IllustratedMessage spectrum-IllustratedMessage--cta">
<svg class="spectrum-IllustratedMessage-illustration" width="199" height="98" viewBox="0 0 199 97.7"><defs><style>.cls-1,.cls-2{fill:none;stroke-linecap:round;stroke-linejoin:round;}.cls-1{stroke-width:3px;}.cls-2{stroke-width:2px;}</style></defs><path class="cls-1" d="M110.53,85.66,100.26,95.89a1.09,1.09,0,0,1-1.52,0L88.47,85.66"/><line class="cls-1" x1="99.5" y1="95.5" x2="99.5" y2="58.5"/><path class="cls-1" d="M105.5,73.5h19a2,2,0,0,0,2-2v-43"/><path class="cls-1" d="M126.5,22.5h-19a2,2,0,0,1-2-2V1.5h-31a2,2,0,0,0-2,2v68a2,2,0,0,0,2,2h19"/><line class="cls-1" x1="105.5" y1="1.5" x2="126.5" y2="22.5"/><path class="cls-2" d="M47.93,50.49a5,5,0,1,0-4.83-5A4.93,4.93,0,0,0,47.93,50.49Z"/><path class="cls-2" d="M36.6,65.93,42.05,60A2.06,2.06,0,0,1,45,60l12.68,13.2"/><path class="cls-2" d="M3.14,73.23,22.42,53.76a1.65,1.65,0,0,1,2.38,0l19.05,19.7"/><path class="cls-1" d="M139.5,36.5H196A1.49,1.49,0,0,1,197.5,38V72A1.49,1.49,0,0,1,196,73.5H141A1.49,1.49,0,0,1,139.5,72V32A1.49,1.49,0,0,1,141,30.5H154a2.43,2.43,0,0,1,1.67.66l6,5.66"/><rect class="cls-1" x="1.5" y="34.5" width="58" height="39" rx="2" ry="2"/></svg>
<h2 class="spectrum-Heading spectrum-Heading--pageTitle spectrum-IllustratedMessage-heading">Drag and Drop Your File</h2>
<h2 class="spectrum-Heading--pageTitle spectrum-IllustratedMessage-heading">Drag and Drop Your File</h2>
<p class="spectrum-Body--secondary spectrum-IllustratedMessage-description"><a href="#" class="spectrum-Link">Select a File</a> from your computer<br> or <a href="#" class="spectrum-Link">Search Adobe Stock</a></p>
</div>
2 changes: 1 addition & 1 deletion components/site/index.css
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ governing permissions and limitations under the License.

.spectrum-CSSComponent-resource--adobe {
color: rgb(255, 2, 1) !important;
background-color: rgba(255, 2, 1, 0.1) !important;
background-color: var(--spectrum-global-color-gray-100) !important;
}

.spectrum-CSSComponent-resource--github {
Expand Down
Loading