Skip to content

Conversation

castastrophe
Copy link
Collaborator

@castastrophe castastrophe commented Oct 17, 2025

Description

This update removes --mod-asset-* custom property hooks per SWC-1264, see also the RFC for extensible styling. Class selectors and variants remain unchanged; stories were refreshed to match the current API.

  • Remove all --mod-asset-* custom property hooks.
  • Reduces unnecessary re-mapping of custom properties in favor of using them directly

Breaking change: the --mod-asset-* override layer is removed. Consumers should set --spectrum-asset-* variables directly where customization as needed.

Related issue(s)

  • fixes SWC-1264

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes (or confirmed existing coverage is sufficient for styling-only changes).
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a GitHub Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are passing or approved

Validation steps

  • No visual or behavioral changes compared to the current spectrum-two baseline.

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:

    • The pages render correctly, are accessible, and are responsive.
  2. If components have been modified, VRTs have been run on this branch:

    • VRTs have been run and looked at.
    • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Copy link

changeset-bot bot commented Oct 17, 2025

⚠️ No Changeset found

Latest commit: 32de420

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@castastrophe castastrophe self-assigned this Oct 17, 2025
@castastrophe castastrophe added size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete. run_vrt For use on PRs looking to kick off VRT ready-for-review S2 Spectrum 2 labels Oct 17, 2025
Copy link
Contributor

github-actions bot commented Oct 17, 2025

📚 Branch preview

PR #4257 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-4257/index.html.

Copy link
Contributor

github-actions bot commented Oct 17, 2025

File metrics

Summary

Total size: 1.43 MB*

Package Size Minified Gzipped
asset 1.17 KB 1.10 KB 0.59 KB

asset

Filename Head Minified Gzipped Compared to base
index.css 1.17 KB 1.10 KB 0.59 KB 🟢 ⬇ 0.86 KB
metadata.json 0.49 KB - - 🟢 ⬇ 0.47 KB
* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@castastrophe castastrophe force-pushed the castastrophe/feat-asset-modifier-removal branch from 056c87a to 32de420 Compare October 17, 2025 20:07
@castastrophe castastrophe enabled auto-merge (squash) October 17, 2025 20:07
@castastrophe castastrophe merged commit 5b4bd5f into spectrum-two Oct 17, 2025
16 of 26 checks passed
@castastrophe castastrophe deleted the castastrophe/feat-asset-modifier-removal branch October 17, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review run_vrt For use on PRs looking to kick off VRT S2 Spectrum 2 size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants