Skip to content

Conversation

@hunterloftis
Copy link
Contributor

Description

Implements the Badge component.

Related issue(s)

#1643

Motivation and context

Expanding component coverage

How has this been tested?

  1. Go to the preview storybook
  2. Check out the various examples of badge usage
  3. Go to the preview docs site
  4. Check out the documentation

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@github-actions
Copy link
Contributor

Tachometer results

Currently, no packages are changed by this PR...

Copy link
Contributor

@Westbrook Westbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super excited to see this FINALLY landing!

najikahalsema
najikahalsema previously approved these changes May 26, 2022
Copy link
Member

@najikahalsema najikahalsema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Nice work, Hunter!

Copy link
Contributor

@Westbrook Westbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! 💯 Thanks for the slog with the various teams to bring this over the line. 🙇🏼‍♂️ With this I dare say that you onboarding is finally complete 😜

@Westbrook Westbrook merged commit e73fb87 into main May 26, 2022
@Westbrook Westbrook deleted the hunterloftis/badge branch May 26, 2022 21:47
@Westbrook Westbrook mentioned this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants