Skip to content

fix: fast forward changes in #2905 #3134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2023
Merged

fix: fast forward changes in #2905 #3134

merged 1 commit into from
Apr 20, 2023

Conversation

@Westbrook
Copy link
Contributor

@Westbrook Westbrook commented Apr 20, 2023

Description

While we don't have a more precise timeline for #2905, fast forward some of the fixes therein.

Related issue(s)

How has this been tested?

  • Test case 1
    1. Go here
    2. See the cursor: pointer when hovering the track with you mouse
    3. See the animation when interacting with the handle.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2023

Branch Preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2023 •
edited
Loading

Tachometer results

Chrome

action-bar permalink

Version Bytes Avg Time vs remote vs branch
npm latest 286 kB 29.84ms - 30.34ms - faster ✔
4% - 7%
1.23ms - 2.35ms
branch 341 kB 31.38ms - 32.38ms slower ❌
4% - 8%
1.23ms - 2.35ms		 -

action-menu permalink

Version Bytes Avg Time vs remote vs branch
npm latest 646 kB 166.07ms - 172.01ms - unsure 🔍
-2% - +2%
-3.71ms - +4.10ms
branch 702 kB 166.31ms - 171.37ms unsure 🔍
-2% - +2%
-4.10ms - +3.71ms		 -

card permalink

Version Bytes Avg Time vs remote vs branch
npm latest 440 kB 79.54ms - 80.95ms - faster ✔
5% - 7%
3.89ms - 6.06ms
branch 479 kB 84.39ms - 86.05ms slower ❌
5% - 8%
3.89ms - 6.06ms		 -

illustrated-message permalink

Version Bytes Avg Time vs remote vs branch
npm latest 338 kB 36.89ms - 37.23ms - faster ✔
13% - 14%
5.44ms - 6.03ms
branch 379 kB 42.56ms - 43.04ms slower ❌
15% - 16%
5.44ms - 6.03ms		 -

menu permalink

Version Bytes Avg Time vs remote vs branch
npm latest 354 kB 209.53ms - 214.09ms - unsure 🔍
-1% - +2%
-2.16ms - +3.24ms
branch 409 kB 209.82ms - 212.72ms unsure 🔍
-2% - +1%
-3.24ms - +2.16ms		 -

overlay permalink

Version Bytes Avg Time vs remote vs branch
npm latest 373 kB 66.23ms - 67.26ms - faster ✔
1% - 3%
0.73ms - 2.17ms
branch 427 kB 67.68ms - 68.70ms slower ❌
1% - 3%
0.73ms - 2.17ms		 -

picker permalink

Version Bytes Avg Time vs remote vs branch
npm latest 503 kB 555.38ms - 564.39ms - unsure 🔍
-0% - +2%
-0.21ms - +10.51ms
branch 559 kB 551.83ms - 557.64ms unsure 🔍
-2% - +0%
-10.51ms - +0.21ms		 -

popover permalink

Version Bytes Avg Time vs remote vs branch
npm latest 283 kB 29.41ms - 29.61ms - faster ✔
5% - 7%
1.67ms - 2.12ms
branch 338 kB 31.21ms - 31.61ms slower ❌
6% - 7%
1.67ms - 2.12ms		 -

slider permalink

Version Bytes Avg Time vs remote vs branch
npm latest 387 kB 131.79ms - 134.32ms - faster ✔
0% - 3%
0.17ms - 3.81ms
branch 442 kB 133.74ms - 136.35ms slower ❌
0% - 3%
0.17ms - 3.81ms		 -

split-button permalink

Version Bytes Avg Time vs remote vs branch
npm latest 580 kB 2025.92ms - 2028.91ms - unsure 🔍
-0% - -0%
-7.09ms - -1.67ms
branch 636 kB 2029.53ms - 2034.06ms unsure 🔍
+0% - +0%
+1.67ms - +7.09ms		 -

tooltip permalink

Version Bytes Avg Time vs remote vs branch
npm latest 296 kB 30.72ms - 30.93ms - faster ✔
6% - 7%
2.10ms - 2.41ms
branch 351 kB 32.96ms - 33.20ms slower ❌
7% - 8%
2.10ms - 2.41ms		 -
Firefox

action-bar permalink

Version Bytes Avg Time vs remote vs branch
npm latest 286 kB 104.86ms - 114.78ms - unsure 🔍
-9% - +2%
-10.06ms - +2.74ms
branch 341 kB 109.44ms - 117.52ms unsure 🔍
-3% - +9%
-2.74ms - +10.06ms		 -

action-menu permalink

Version Bytes Avg Time vs remote vs branch
npm latest 646 kB 391.39ms - 406.29ms - unsure 🔍
-2% - +3%
-8.91ms - +10.67ms
branch 702 kB 391.60ms - 404.32ms unsure 🔍
-3% - +2%
-10.67ms - +8.91ms		 -

card permalink

Version Bytes Avg Time vs remote vs branch
npm latest 440 kB 181.19ms - 190.89ms - faster ✔
13% - 19%
29.00ms - 42.00ms
branch 479 kB 217.22ms - 225.86ms slower ❌
15% - 23%
29.00ms - 42.00ms		 -

illustrated-message permalink

Version Bytes Avg Time vs remote vs branch
npm latest 338 kB 85.34ms - 92.18ms - faster ✔
33% - 40%
44.53ms - 56.55ms
branch 379 kB 134.36ms - 144.24ms slower ❌
49% - 65%
44.53ms - 56.55ms		 -

menu permalink

Version Bytes Avg Time vs remote vs branch
npm latest 354 kB 519.16ms - 535.16ms - unsure 🔍
-3% - +0%
-18.66ms - +1.70ms
branch 409 kB 529.36ms - 541.92ms unsure 🔍
-0% - +4%
-1.70ms - +18.66ms		 -

overlay permalink

Version Bytes Avg Time vs remote vs branch
npm latest 373 kB 159.80ms - 167.56ms - unsure 🔍
-7% - +0%
-12.34ms - +0.94ms
branch 427 kB 164.00ms - 174.76ms unsure 🔍
-1% - +8%
-0.94ms - +12.34ms		 -

picker permalink

Version Bytes Avg Time vs remote vs branch
npm latest 503 kB 1054.69ms - 1082.11ms - unsure 🔍
-2% - +2%
-18.63ms - +23.47ms
branch 559 kB 1050.00ms - 1081.96ms unsure 🔍
-2% - +2%
-23.47ms - +18.63ms		 -

popover permalink

Version Bytes Avg Time vs remote vs branch
npm latest 283 kB 88.96ms - 103.52ms - unsure 🔍
-17% - +3%
-17.67ms - +3.51ms
branch 338 kB 95.63ms - 111.01ms unsure 🔍
-4% - +19%
-3.51ms - +17.67ms		 -

slider permalink

Version Bytes Avg Time vs remote vs branch
npm latest 387 kB 358.26ms - 367.82ms - unsure 🔍
-3% - +1%
-9.36ms - +2.88ms
branch 442 kB 362.46ms - 370.10ms unsure 🔍
-1% - +3%
-2.88ms - +9.36ms		 -

split-button permalink

Version Bytes Avg Time vs remote vs branch
npm latest 580 kB 2148.59ms - 2161.21ms - unsure 🔍
-1% - +0%
-12.81ms - +2.89ms
branch 636 kB 2155.19ms - 2164.53ms unsure 🔍
-0% - +1%
-2.89ms - +12.81ms		 -

tooltip permalink

Version Bytes Avg Time vs remote vs branch
npm latest 296 kB 74.37ms - 78.51ms - faster ✔
8% - 19%
6.54ms - 17.86ms
branch 351 kB 83.37ms - 93.91ms slower ❌
8% - 24%
6.54ms - 17.86ms		 -

@beeduul beeduul self-requested a review April 20, 2023 22:26
beeduul
beeduul previously approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@beeduul beeduul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - i confirmed out both updated behaviors (pointer hover change & handle interaction animation)

@Westbrook Westbrook merged commit 3a30b27 into main Apr 20, 2023
@Westbrook Westbrook deleted the slider-ff branch April 20, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beeduul beeduul beeduul left review comments

@hunterloftis hunterloftis Awaiting requested review from hunterloftis

@spdev3000 spdev3000 Awaiting requested review from spdev3000

@najikahalsema najikahalsema Awaiting requested review from najikahalsema

@pfulton pfulton Awaiting requested review from pfulton

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feat]: Cursor refinement over slider parts [Feat]: SliderHandle animation onPointerdown

3 participants

@Westbrook @beeduul