chore(theme): include custom var css files in theme imports #3363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
najikahalsema
changed the title
Contributor
Westbrook
reviewed
Jun 26, 2023
Contributor
Westbrook
left a comment
Westbrook
left a comment
There was a problem hiding this comment.
Great start. Don't forget to do the same for the Express files.
najikahalsema
force-pushed
the
halsema/include-custom-vars-imports
branch
from
a49b957 to
5f26022
Compare
Contributor
Tachometer resultsChromeaction-bar permalink
action-menu permalink
menu permalink
overlay permalink
picker permalink
popover permalink
slider permalink
split-button permalink
tooltip permalink
Firefoxaction-bar permalink
action-menu permalink
menu permalink
overlay permalink
picker permalink
popover permalink
slider permalink
split-button permalink
tooltip permalink
|
Member
Author
|
vrts are failing as expected on Dragged dropzone story, as those vars weren't getting into the component before now. |
Contributor
|
Looks good here! Cycle the VRT hash and this should be good to go. |
najikahalsema
force-pushed
the
halsema/include-custom-vars-imports
branch
from
b10c30a to
e9e9419
Compare
najikahalsema
force-pushed
the
halsema/include-custom-vars-imports
branch
from
25bc303 to
31192df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of the files within the Spectrum CSS core tokens packages weren't being imported to be used in the
themetools, even though we are importing them in thestylestools. Added imports for these files so that we can consume these custom variables, as well.Related issue(s)
Motivation and context
Missing import
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.