-
Notifications
You must be signed in to change notification settings - Fork 235
docs: improves documentation for invalid selections in radio groups #3558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
6 tasks
Contributor
Tachometer resultsChromeradio permalink
Firefoxradio permalink
|
Rajdeepc
previously approved these changes
Aug 22, 2023
Westbrook
reviewed
Aug 22, 2023
505bf60 to
5af9536
Compare
1 task
5af9536 to
244949f
Compare
Westbrook
approved these changes
Aug 23, 2023
Contributor
Westbrook
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ![]()
Thanks @jnjosh 🙇
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated documentation for radio button to show proper usage of an invalid radio group. Additionally, directed readers to read more about help text. Also, opened equivalent PR to CSS project.
Related issue(s)
Issue #3005
Motivation and context
Clearer documentation is always good.
How has this been tested?
Documentation only change.
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.