Skip to content

Conversation

@jnjosh
Copy link
Collaborator

@jnjosh jnjosh commented Aug 18, 2023

Updated documentation for radio button to show proper usage of an invalid radio group. Additionally, directed readers to read more about help text. Also, opened equivalent PR to CSS project.

Related issue(s)

Issue #3005

Motivation and context

Clearer documentation is always good.

How has this been tested?

Documentation only change.

Screenshots (if appropriate)

Screenshot 2023-08-18 at 10 41 56 AM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • [-] I have added tests to cover my changes.
  • [-] All new and existing tests passed.
  • [-] I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@jnjosh jnjosh self-assigned this Aug 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2023

Tachometer results

Chrome

radio permalink

Version Bytes Avg Time vs remote vs branch
npm latest 400 kB 121.38ms - 123.42ms - unsure 🔍
-1% - +2%
-0.70ms - +2.22ms
branch 395 kB 120.60ms - 122.68ms unsure 🔍
-2% - +1%
-2.22ms - +0.70ms
-
Firefox

radio permalink

Version Bytes Avg Time vs remote vs branch
npm latest 400 kB 412.08ms - 438.88ms - unsure 🔍
-3% - +5%
-12.93ms - +21.37ms
branch 395 kB 410.56ms - 431.96ms unsure 🔍
-5% - +3%
-21.37ms - +12.93ms
-

@jnjosh jnjosh requested review from Rajdeepc and Westbrook August 21, 2023 19:12
Rajdeepc
Rajdeepc previously approved these changes Aug 22, 2023
@jnjosh jnjosh force-pushed the jnjosh/3005-invalid-radio branch from 5af9536 to 244949f Compare August 22, 2023 20:31
@jnjosh jnjosh changed the title fix(radio): fix radio documentation for invalid radio groups docs: improves documentation for invalid selections in radio groups Aug 22, 2023
Copy link
Contributor

@Westbrook Westbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

Thanks @jnjosh 🙇

@Westbrook Westbrook merged commit d1f8208 into main Aug 23, 2023
@Westbrook Westbrook deleted the jnjosh/3005-invalid-radio branch August 23, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants