-
Couldn't load subscription status.
- Fork 235
test(picker): enable webkit tab navigation tests #5833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Pull Request Test Coverage Report for Build 18852189534Details
💛 - Coveralls |
Tachometer resultsCurrently, no packages are changed by this PR... |
| const input = document.createElement('input'); | ||
| el.insertAdjacentElement('afterend', input); | ||
|
|
||
| el.focus(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiosity, did you try removing the el.focus and see if that still passes? i believe that was the webkit work around but now that our keyboard helpers account for webkit weirdness we might be able to remove those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell we need still need el.focus for the setup, when I took it out the tests timed out locally 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Removes
!isWebKit()conditionals from two picker tests that were skipping tab key navigation validation in Safari/WebKit browsers. These conditionals were likely added because Safari's default tab behavior only focused form controls, not all interactive elements.Changes:
if (!isWebKit())wrapper from "closes when focusing away from the menu" test (line ~1088)if (!isWebKit())wrapper from similar tab navigation validation (line ~1125)Motivation and context
This addresses a reported accessibility issue where the Picker component could not be tabbed into in Safari within Storybook.
Investigation findings:
Related issue(s)
Author's checklist
I have included a well-written changeset if my change needs to be published.I have included updated documentation if my change required it.Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Verify picker tests pass locally:
yarn test:focus pickerConfirm that bug cannot be replicated with appropriate settings on:
Device review