Skip to content

Conversation

@Rajdeepc
Copy link
Contributor

@Rajdeepc Rajdeepc commented Nov 12, 2025

Description

The SWC_DIR environment variable in CircleCI's beta-docs job was not being exported, so the rollup build process couldn't access it to prefix asset paths.

Fix

File: .circleci/config.yml

Changed from:

- run:
    name: Build documentation with path prefix
    command: echo "SWC_DIR=beta/docs" >> $BASH_ENV

To:

- run:
    name: Build documentation with path prefix
    command: |
        echo "export SWC_DIR=beta/docs" >> $BASH_ENV
        source $BASH_ENV

Motivation and context

Related issue(s)

  • fixes [Issue Number]

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Test beta-docs deploy

    1. Go here
    2. beta-docs look fine now :)

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2025

⚠️ No Changeset found

Latest commit: 7941344

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5877

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@TarunAdobe TarunAdobe marked this pull request as ready for review November 12, 2025 10:06
@TarunAdobe TarunAdobe requested a review from a team as a code owner November 12, 2025 10:06
Copy link
Contributor

@TarunAdobe TarunAdobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHIP IT!

@Rajdeepc Rajdeepc added the Status: Ready for review PR ready for review or re-review. label Nov 12, 2025
@TarunAdobe TarunAdobe force-pushed the rajdeep/circleci-beta-docs branch from f5c2af3 to 7941344 Compare November 13, 2025 01:56
@Rajdeepc Rajdeepc merged commit a374260 into main Nov 13, 2025
22 checks passed
@Rajdeepc Rajdeepc deleted the rajdeep/circleci-beta-docs branch November 13, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Ready for review PR ready for review or re-review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants