feat: add s2 static colors #5902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 81e1318 The changes in this PR will be included in the next version bump. This PR includes changesets to release 78 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
TarunAdobe
approved these changes
Nov 21, 2025
Contributor
TarunAdobe
left a comment
TarunAdobe
left a comment
There was a problem hiding this comment.
Thank you for adding this!
Adds the Spectrum 2 static colors from Spectrum Tokens, manually.
TarunAdobe
force-pushed
the
feat--add-s2-static-colors
branch
from
c01ee66 to
94a7c60
Compare
Rajdeepc
approved these changes
Nov 21, 2025
Contributor
Rajdeepc
left a comment
Rajdeepc
left a comment
There was a problem hiding this comment.
Verified in the doc site, we are able to see the definitions of static tokens.
Rajdeepc
added
Status: Ready for merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the Spectrum 2 static colors from Spectrum Tokens via manual definitions.
Specifically, the values defined here match (at the time of authorship) the Spectrum Tokens static color values here.
These are considered additive to the system and should not cause any visual differences.
Motivation and context
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Verify that static values are present in s2 theme
spectrum-twotheme and open chrome dev tools--spectrum-static-blue-900-rgb(or something similar) and verify that it is present in the stylesheetDevice review