Skip to content

Conversation

@herzog31
Copy link
Member

Description

  • This PR allows the position of an item in BreadcrumbList to be a non-numeric string to be compliant with https://schema.org/position.
  • This change required the logic to determine the last item in the list to change:
    • Determining the last item in the list is only possible, if all position values are either numbers or strings that can be parsed as number. The last item is not required to have an item attribute.
    • If just a single position value is a string, no last element can be determined and every list item is required to have an item attribute with a valid URL.
    • This behaviour is consistent with the Google Rich Results validator.

How Has This Been Tested?

  • Added new unit test and verified existing tests still pass.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@herzog31 herzog31 added the bug Something isn't working label Jul 15, 2025
@herzog31 herzog31 merged commit 052b443 into main Jul 16, 2025
4 checks passed
@herzog31 herzog31 deleted the breadcrumb-position branch July 16, 2025 08:36
github-actions bot pushed a commit that referenced this pull request Jul 16, 2025
## [1.2.3](v1.2.2...v1.2.3) (2025-07-16)

### Bug Fixes

* Adjust breadcrumb position logic ([#29](#29)) ([052b443](052b443))
@github-actions
Copy link

🎉 This PR is included in version 1.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

herzog31 added a commit to adobe/spacecat-audit-worker that referenced this pull request Jul 17, 2025
* Manually upgrading the `@adobe/structured-data-validator` dependency
to 1.2.3.
* Includes the following fixes:
    * adobe/structured-data-validator#26
    * adobe/structured-data-validator#27
    * adobe/structured-data-validator#29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant