fix: config API bugs, ESP PR #962 custom attributes, scope mismatch fix#162
Merged
Conversation
Three structural correctness fixes around rsvpFormFields:
- Add 'rsvpFormFields' to speciallyHandledFields so the generic
EVENT_DATA_FILTER loop does not double-process the field alongside
the explicit payload block.
- Guard rsvpFormFields payload assembly with Array.isArray so empty
arrays and non-array form state values are not serialized as
{ fields: [] } (BE rejects non-object/empty values).
- Surface the actual BE error message on save failures by reading
result.error.message instead of result.message, which was always
undefined and caused all save errors to fall back to the generic
'Failed to update/create event' string.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
qiyundai
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?type=query param fromgetConfigsForScope— ESP returns 400 on unknown query params; now filters client-sidescopeIdtocreateConfigPOST body — ESP requires it in the body, not just the URLConfigManagement.tsxwith a proper error toastvisibleRsvpFields/requiredRsvpFieldsfields; updated test fixtures to new{ fields: [...] }rsvpFormFields shapeenabledAttributeIdsfieldenabledAttributeIdsTest plan
customAttributesas IDs-only andenabledAttributeIdspresentenabledAttributeIdsin PUT payload is NOT{ "event": [], "session": [] }🤖 Generated with Claude Code