chore: rsvpFormFields BE shape migration shim (legacy-first order)#166
Merged
Merged
Conversation
Re-applies transitional dual-shape support for rsvpFormFields with save
order corrected: legacy {required, visible} shape is sent first; the new
{fields} shape is the fallback retry on rejection. Previous version was
reverted because it sent new shape first, which fails against the current
BE before ESP PR #903 ships.
Save side (useEventFormSave.ts):
- Primary call converts rsvpFormFields to legacy shape before sending.
- Retry with new {fields} shape only if BE rejects with a
rsvpFormFields-flavored 400 (post-#903 environments).
Read side (eventFormMappers.ts):
- readRsvpFormFields() adapts either GET shape to the array the form
expects, so events stored under the legacy shape open correctly on edit.
All temporary code tagged `rsvp-shape-migration` for clean grep-and-delete
once ESP PR #903 ships everywhere.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Revert this PR once BE fixes RSVP and migrates changes. This is only for an interim purpose and should not be retained for long. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-applies transitional dual-shape support for rsvpFormFields with save order corrected: legacy {required, visible} shape is sent first; the new {fields} shape is the fallback retry on rejection. Previous version was reverted because it sent new shape first, which fails against the current BE before ESP PR #903 ships.
Save side (useEventFormSave.ts):
Read side (eventFormMappers.ts):
All temporary code tagged
rsvp-shape-migrationfor clean grep-and-delete once ESP PR #903 ships everywhere.