fix(series): include scopeId in PUT payload#169
Merged
Conversation
ESP returns scopeId on GET but SERIES_DATA_FILTER stripped it on PUT, causing scope membership to be lost on series update/publish/unpublish/ archive. Add scopeId to the filter (updatable, not cloneable) and thread it from the loaded canonical response into SeriesForm's buildApiPayload. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
sirivuri
approved these changes
May 28, 2026
qiyundai
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scopeIdon GET series butSERIES_DATA_FILTERstripped it on PUT, so scope membership was being dropped on every series update / publish / unpublish / archive.scopeIdtoSERIES_DATA_FILTERassubmittable: true, updatable: true, cloneable: false(clones should derive scope from the active scope context, not the source series).scopeIdfrom the loaded canonicalSeriesApiResponseintoSeriesForm'sbuildApiPayloadso it survives both filter passes (the form-level filter andprepareEspSeriesPutPayloadinside the API service).SeriesDashboard's publish/unpublish/archive flows already pass the fullSeriesApiResponse, so the filter change covers them automatically.Test plan
scopeIdmatching the value returned on GET.SeriesDashboard— verify each PUT includesscopeId.scopeIdreturned by the create call.scopeId).🤖 Generated with Claude Code