Skip to content

DOTCOM-179904: [Doodlebug] [Carousel] Added hover effect for nav-buttons#901

Merged
nkthakur48 merged 5 commits intostagefrom
DOTCOM-179824-carousel-hover
Mar 6, 2026
Merged

DOTCOM-179904: [Doodlebug] [Carousel] Added hover effect for nav-buttons#901
nkthakur48 merged 5 commits intostagefrom
DOTCOM-179824-carousel-hover

Conversation

@nkthakur48
Copy link
Collaborator

@aem-code-sync
Copy link

aem-code-sync bot commented Mar 6, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link

aem-code-sync bot commented Mar 6, 2026

Page Scores Audits Google
📱 /drafts/doodlebug/remove-object PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/doodlebug/remove-object PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to DOTCOM-179824-carousel-hover March 6, 2026 05:21 Inactive
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.87%. Comparing base (5bec115) to head (ccb9e5e).
⚠️ Report is 34 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #901      +/-   ##
==========================================
- Coverage   88.68%   87.87%   -0.81%     
==========================================
  Files          42       41       -1     
  Lines        9146     8997     -149     
==========================================
- Hits         8111     7906     -205     
- Misses       1035     1091      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@drashti1712
Copy link
Collaborator

@nkthakur48 Is it expected that the carousel-prompt should disappear on hover of the buttons?

@nkthakur48
Copy link
Collaborator Author

@drashti1712 I suppose yes. @suhjainadobe Could you confirm please?

@aem-code-sync aem-code-sync bot temporarily deployed to DOTCOM-179824-carousel-hover March 6, 2026 15:57 Inactive
@suhjainadobe
Copy link
Contributor

@nkthakur48 Is it expected that the carousel-prompt should disappear on hover of the buttons?

@drashti1712 : this is the expected behaviour . Prompt comes up only on card hover not on buttons.

@spadmasa
Copy link
Collaborator

spadmasa commented Mar 6, 2026

@nkthakur48 nkthakur48 merged commit c7cff1e into stage Mar 6, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants