MWPW-191633: Adds to setLibs array to allow the use of milolibs= on stage#962
MWPW-191633: Adds to setLibs array to allow the use of milolibs= on stage#962nkthakur48 merged 6 commits intostagefrom
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
|
Skipped merging 962: Adds to setLibs array to allow the use of milolibs= on stage due to failing checks |
| && !hostname.includes('aem.page') | ||
| && !hostname.includes('aem.live') | ||
| && !hostname.includes('localhost')) { | ||
| if (!['.aem.', '.hlx.', '.stage.', 'local', '.da.'].some((i) => hostname.includes(i))) { |
There was a problem hiding this comment.
@JasonHowellSlavin: I see that the localhost has been renamed as local. Could you please confirm whether this is intentional?
There was a problem hiding this comment.
re-added, same as da-cc
|
Skipped merging 962: Adds to setLibs array to allow the use of milolibs= on stage due to failing checks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stage #962 +/- ##
==========================================
- Coverage 88.37% 88.14% -0.24%
==========================================
Files 42 42
Lines 9277 9246 -31
==========================================
- Hits 8199 8150 -49
- Misses 1078 1096 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Skipped merging 962: Adds to setLibs array to allow the use of milolibs= on stage due to failing checks |
nkthakur48
changed the title
|
Skipped merging 962: MWPW-191633: Adds to setLibs array to allow the use of milolibs= on stage due to failing checks |
|
Since this fix could only be tested on stage, it was merged without labels. |
3 participants
.stage.to allow the use of?milolibs={branch}on www.stage.adobe.comTest URLs:
Verification
Verification was done to ensure that milolibs and libs get set as expected on this repository. To check against www.stage.adobe.com local overrides were used before making code changes in the repository.