[SR] Bento variant addition and VQA #5992
Merged
Merged
Conversation
added 4 commits
May 22, 2026 15:08
…dback. Setting max-width for full-width bentos body.
Contributor
JingleH
approved these changes
May 28, 2026
robert-bogos
approved these changes
May 29, 2026
Comment on lines
+62
to
+66
| if (!el.classList.contains('show-link')) link.remove(); | ||
| if (el.classList.contains('show-link')) { | ||
| link.classList.add('standalone-link', 'label'); | ||
| link.setAttribute('tabindex', '-1'); | ||
| } |
Contributor
There was a problem hiding this comment.
nit to make this less wordy
Suggested change
| if (!el.classList.contains('show-link')) link.remove(); | |
| if (el.classList.contains('show-link')) { | |
| link.classList.add('standalone-link', 'label'); | |
| link.setAttribute('tabindex', '-1'); | |
| } | |
| if (el.classList.contains('show-link')) { | |
| link.classList.add('standalone-link', 'label'); | |
| link.setAttribute('tabindex', '-1'); | |
| } else link.remove(); |
DKos95
approved these changes
May 29, 2026
zagi25
approved these changes
May 29, 2026
NadiiaSokolova
approved these changes
May 29, 2026
Contributor
NadiiaSokolova
left a comment
There was a problem hiding this comment.
Verified. Ready to be merged.
Testing details MWPW-193260
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scrim).max-widthfor tablet up on body copy in bentos usingfull-width gridsetting.max-widthfor body and heading copy in bentos usingcentervariant.show-link).show-linkvariant (tint, image scale).Resolves:
Test URLs: