Skip to content

[SR] Bento variant addition and VQA #5992

Merged
rgclayton merged 5 commits into
site-redesign-foundationfrom
sr-bento-overlay
May 29, 2026
Merged

[SR] Bento variant addition and VQA #5992
rgclayton merged 5 commits into
site-redesign-foundationfrom
sr-bento-overlay

Conversation

@rgclayton
Copy link
Copy Markdown
Contributor

@rgclayton rgclayton commented May 28, 2026

  • Added scrim variant to enable per bento block - fine tuned for bento block (scrim).
  • Set max-width for tablet up on body copy in bentos using full-width grid setting.
  • Set max-width for body and heading copy in bentos using center variant.
  • Added new variant to show link text as an option for bentos with links (show-link).
  • Added new hover for show-link variant (tint, image scale).
  • Fixed tabbing focus-ring issue noted by QA.
  • Addressing VQA feedback (spacing, body color, adjust aspect ratio)

Resolves:

Test URLs:

@aem-code-sync
Copy link
Copy Markdown
Contributor

aem-code-sync Bot commented May 28, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@rgclayton rgclayton changed the title [SR] Bento variant updates and VQA [SR] Bento variant additions and VQA May 28, 2026
@rgclayton rgclayton changed the title [SR] Bento variant additions and VQA [SR] Bento variant addition and VQA May 28, 2026
Comment on lines +62 to +66
if (!el.classList.contains('show-link')) link.remove();
if (el.classList.contains('show-link')) {
link.classList.add('standalone-link', 'label');
link.setAttribute('tabindex', '-1');
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit to make this less wordy

Suggested change
if (!el.classList.contains('show-link')) link.remove();
if (el.classList.contains('show-link')) {
link.classList.add('standalone-link', 'label');
link.setAttribute('tabindex', '-1');
}
if (el.classList.contains('show-link')) {
link.classList.add('standalone-link', 'label');
link.setAttribute('tabindex', '-1');
} else link.remove();

Copy link
Copy Markdown
Contributor

@NadiiaSokolova NadiiaSokolova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. Ready to be merged.
Testing details MWPW-193260

@rgclayton rgclayton merged commit 7f2d139 into site-redesign-foundation May 29, 2026
8 checks passed
@rgclayton rgclayton deleted the sr-bento-overlay branch May 29, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants