MWPW-191927 Implementing Config-Based A/B Testing#747
Merged
Conversation
shasmish
reviewed
Apr 20, 2026
|
|
||
| export async function fetchPageConfig({ product, verb }) { | ||
| try { | ||
| const url = `${unityConfig.pageConfigEndPoint}?product=${product}&action=${verb}`; |
Collaborator
There was a problem hiding this comment.
We renamed the action query param to verb to keep it consistent with other implementation.
Collaborator
Author
There was a problem hiding this comment.
Got it, have updated accordingly.
Ruchika4
approved these changes
Apr 20, 2026
| const verb = this.workflowCfg.enabledFeatures[0]; | ||
| try { | ||
| const { fetchPageConfig } = await import('../../../scripts/utils.js'); | ||
| const { default: getExperimentData } = await import('../../../utils/experiment-provider.js'); |
Collaborator
There was a problem hiding this comment.
Should this be imported when target is enabled?
Collaborator
Author
There was a problem hiding this comment.
Since it was required in both if and else conditions, I kept it outside for now. But I agree, it should only be required when target is enabled and will make this change once we can remove the backwards-compatibility.
shasmish
approved these changes
Apr 23, 2026
Ruchika4
pushed a commit
that referenced
this pull request
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-191927
Test URLs: