Wave 2.1 - Upscale video changes#752
Merged
arugupta1992 merged 3 commits intowave2-videofrom Apr 27, 2026
Merged
Conversation
sanjayms01
reviewed
Apr 26, 2026
| } | ||
| try { await this.checkImageDimensions(file); } catch (error) { | ||
| window.lana?.log(`Message: Error checking image dimensions, Error: ${error}`, this.lanaOptions); | ||
| const isVideo = file.type.startsWith('video/'); |
Collaborator
There was a problem hiding this comment.
Should we be solely relying on mime type here or should we check for extension?
Collaborator
Author
There was a problem hiding this comment.
If the mimetype matches and file extension does not then the control will exit from line 457 above. If control reaches this check that means file extensions are valid, so I think we can keep mimetype here to just check if it's video or image. wdyt?
Collaborator
There was a problem hiding this comment.
That's a fair point, we can leave as is given we have proper check beforehand.
sanjayms01
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing Notes:
Resolves: MWPW-NUMBER
Test URLs: