Skip to content

Revert "Don't wait for finalize" #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ruchika4 merged 1 commit into from
May 27, 2026
Merged

Revert "Don't wait for finalize" #792

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 37 additions & 4 deletions unitylibs/core/workflow/workflow-acrobat/upload-handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,13 +211,46 @@ export default class UploadHandler {
this.actionBinder.getAdditionalHeaders() || {},
{ body: JSON.stringify(finalAssetData), signal },
);
finalizeOpts.keepalive = true;
this.networkUtils.fetchFromServiceWithRetry(
const finalizeJson = await this.networkUtils.fetchFromServiceWithRetry(
this.actionBinder.acrobatApiConfig.acrobatEndpoint.finalizeAsset,
finalizeOpts,
this.actionBinder.workflowCfg.targetCfg.fetchApiConfig.finalizeAsset,
).catch(() => {});
} catch (e) { /* fire-and-forget */ }
);
if (!finalizeJson || Object.keys(finalizeJson).length !== 0) {
if (this.actionBinder.MULTI_FILE) {
await this.actionBinder.dispatchErrorToast('upload_error_finalize_asset', 500, `Unexpected response from finalize call: ${assetData.id}, ${JSON.stringify(finalizeJson || {})}`, false, true, {
code: 'upload_error_finalize_asset',
desc: `Unexpected response from finalize call: ${assetData.id}, ${JSON.stringify(finalizeJson || {})}`,
});
return false;
}
await this.showSplashScreen();
await this.actionBinder.dispatchErrorToast('upload_error_finalize_asset', 500, `Unexpected response from finalize call: ${assetData.id}, ${JSON.stringify(finalizeJson)}`, false, true, {
code: 'upload_error_finalize_asset',
desc: `Unexpected response from finalize call: ${assetData.id}, ${JSON.stringify(finalizeJson)}`,
});
this.actionBinder.operations = [];
return false;
}
} catch (e) {
if (e.name === 'AbortError') return false;
if (this.actionBinder.MULTI_FILE) {
await this.actionBinder.dispatchErrorToast('upload_error_finalize_asset', e.status || 500, `Exception thrown when verifying content: ${e.message}, ${assetData.id}`, false, e.showError, {
code: 'upload_error_finalize_asset',
subCode: e.status,
desc: `Exception thrown when verifying content: ${e.message}, ${assetData.id}`,
});
return false;
}
await this.showSplashScreen();
await this.actionBinder.dispatchErrorToast('upload_error_finalize_asset', e.status || 500, `Exception thrown when verifying content: ${e.message}, ${assetData.id}`, false, e.showError, {
code: 'upload_error_finalize_asset',
subCode: e.status,
desc: `Exception thrown when verifying content: ${e.message}, ${assetData.id}`,
});
this.actionBinder.operations = [];
return false;
}
return true;
}

Expand Down
Loading