Changes required in remove background analytics to build splunk dashboard#815
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
| this.sendAnalyticsToSplunk?.( | ||
| eventName, | ||
| this.workflowCfg.productName, | ||
| this.getAnalyticsMeta(data), |
There was a problem hiding this comment.
trackEvent already calls this method and we're calling it again here?
There was a problem hiding this comment.
trackEvent calls logAnalyticsinSplunk. Here it is using sendAnalyticsToSplunk. Am i missing anything?
There was a problem hiding this comment.
Sorry I was referring to why getAnalyticsMeta is also being called here when it is called in trackEvent before we logAnalyticsInSplunk.
There was a problem hiding this comment.
Ohh, my bad.
trackEvent is used when analytics are to be pushed to both AA and splunk. For building the splunk dashboard we add few more analytics which are pushed only to splunk, so at those points logAnalyticsinSplunk is called directly. For those cases getAnalyticsMeta is called here.
arugupta1992
changed the title
| this.resultAssetId = null; | ||
| sendAnalyticsEvent(new CustomEvent('Cancel|UnityWidget')); | ||
| this.logAnalyticsinSplunk('Cancel|UnityWidget', { assetId }); | ||
| this.trackEvent('Cancel|UnityWidget', { assetId }); |
There was a problem hiding this comment.
please define this string in analytics.js as we do for other similar strings.
| sendAnalyticsEvent(new CustomEvent('Uploading Started|UnityWidget')); | ||
| const { isGuest } = await isGuestUser(); | ||
| this.isGuestUser = isGuest; | ||
| this.trackEvent('Uploading Started|UnityWidget'); |
There was a problem hiding this comment.
thanks for catching this
* #756 * #778 * #811 * #809 * #814 * #817 * #816 * #806 * #815 * #818 **Test URLs:** *Doodlebug* - Before: https://stage--da-cc--adobecom.aem.page/products/firefly/features/remove-background?unitylibs=main - After: https://stage--da-cc--adobecom.aem.page/products/firefly/features/remove-background?unitylibs=stage *Acrobat* - Before: https://stage--da-express-milo--adobecom.aem.page/drafts/methomas/express/create/resume?unitylibs=main - After: https://stage--da-express-milo--adobecom.aem.page/drafts/methomas/express/create/resume?unitylibs=stage
3 participants
Resolves: MWPW-NUMBER
Test URLs: