Skip to content

Relationship constraints are not being applied when using sub query in whereIn condition #1036

@aadamcik

Description

@aadamcik

Package version

20.6.0

Describe the bug

When using relationship sub query in whereIn() condition, the constraints are not being applied.

For example:

Post.query().whereIn('id', user.related('posts').query().select('id'))

The user_id = ID clause is not being added in this case.

This issue occurs because applyConstraints() is not being called here https://github.com/adonisjs/lucid/blob/develop/src/database/query_builder/chainable.ts#L235.

I will create PR for this shortly.

Reproduction repo

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions