Skip to content

fixes #92 enable jdkRepo#103

Closed
bhuva-v wants to merge 1 commit into
adoptium:masterfrom
bhuva-v:supportJdkRepo
Closed

fixes #92 enable jdkRepo#103
bhuva-v wants to merge 1 commit into
adoptium:masterfrom
bhuva-v:supportJdkRepo

Conversation

@bhuva-v
Copy link
Copy Markdown

@bhuva-v bhuva-v commented Oct 1, 2021

fixes #92

@sophia-guo
Copy link
Copy Markdown
Contributor

The environment variable is JDK_REPO and JDK_BRANCH

Copy link
Copy Markdown
Contributor

@sophia-guo sophia-guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophia-guo
Copy link
Copy Markdown
Contributor

We will also need to update README. I will create a separate issue.

@sophia-guo
Copy link
Copy Markdown
Contributor

@bhuva-v could you resolve the conflicts and commit again? #102 was merged hence you commit got the conflicts. Thanks.

@smlambert
Copy link
Copy Markdown
Contributor

PR needs conflicts resolved @bhuva-v are you able to do that, if that is not possible, let's close this PR.

FYI @sophia-guo

@karianna
Copy link
Copy Markdown
Contributor

@bhuva-v & @sophia-guo - Bump :-)

@sophia-guo sophia-guo closed this Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to support jdk repo and branch

4 participants