Add runtime safeguards for readonly sessions, LLM failures, and summary reuse#39
Closed
junyangyan4-svg wants to merge 1 commit intoadoresever:mainfrom
Closed
Conversation
Owner
|
Thanks for the PR. There are conflicts with main now (llm.ts was updated in #38). Could you rebase onto the latest main and resolve? Also since this is a large change (+485 lines), could you split it into separate PRs for each feature (readonly sessions, LLM failure guard, summary reuse)? That would make review easier. |
917bb9d to
e22f790
Compare
Author
|
I've rebased onto the latest main. You can review the change now. |
This was referenced Apr 5, 2026
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Implementation notes
ReadonlySessionRegistryand skip ingest/afterTurn/compact/session_end maintenance for readonly session patterns likeagent:...:subagent:...,temp:*, andslug-generator-*LlmFailureGuardand pause only on permanent 4xx provider failures while resetting immediately after a successful callmember_signaturefor community summaries, backfill existing rows, and reuse prior summaries/embeddings when the signature matchesREADME.mdandREADME_CN.mdVerification
npm testnpx tsc --noEmit