Seeing PHP errors with the latest version

[gmclelland]

Hi Adrian,

After installing the latest version, I'm seeing the following error

PHP Warning: count(): Parameter must be an array or an object that implements Countable in .../site/modules/TracyDebugger/TracyDebugger.module:1123

ErrorException: count(): Parameter must be an array or an object that implements Countable in /Users/glenn/websites/mysite/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/panels/ProcesswireInfoPanel.php:198
Stack trace:
#0 /Users/glenn/websites/mysite/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/panels/ProcesswireInfoPanel.php(198): Tracy\Bar->Tracy\{closure}(2, 'count(): Parame...', '/Users/glenn/we...', 198, Array)
#1 /Users/glenn/websites/mysite/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-master/src/Tracy/Bar.php(159): ProcesswireInfoPanel->getPanel()
#2 /Users/glenn/websites/mysite/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-master/src/Tracy/Bar.php(108): Tracy\Bar->renderPanels()
#3 /Users/glenn/websites/mysite/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-master/src/Tracy/Debugger.php(272): Tracy\Bar->render()
#4 [internal function]: Tracy\Debugger::shutdownHandler()
#5 {main}

and on another site the same

ErrorException: count(): Parameter must be an array or an object that implements Countable in /Users/glenn/websites/othersite/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/panels/ProcesswireInfoPanel.php:198
Stack trace:
#0 /Users/glenn/websites/othersite/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/panels/ProcesswireInfoPanel.php(198): Tracy\Bar->Tracy\{closure}(2, 'count(): Parame...', '/Users/glenn/we...', 198, Array)
#1 /Users/glenn/websites/othersite/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-master/src/Tracy/Bar.php(159): ProcesswireInfoPanel->getPanel()
#2 /Users/glenn/websites/othersite/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-master/src/Tracy/Bar.php(108): Tracy\Bar->renderPanels()
#3 /Users/glenn/websites/othersite/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-master/src/Tracy/Debugger.php(272): Tracy\Bar->render()
#4 [internal function]: Tracy\Debugger::shutdownHandler()
#5 {main}

I'm running Apache/2.4.28 (Unix) PHP/7.2.0beta3

When I visit the modules page, I also see the following errors:

1x | PHP Warning: count(): Parameter must be an array or an object that implements Countable in .../Inputfield/InputfieldFile/InputfieldFile.module:637
--
1× | PHP Warning: count(): Parameter must be an array or an object that implements Countable in .../Inputfield/InputfieldFile/InputfieldFile.module:229

[adrianbj]

Thanks @gmclelland - looks like some new warnings in PHP 7.2.

Looks like we need to explicitly do an is_array() check before count() now. Can also please file an Issue regarding the InputfieldFile.module issue on the PW issues repo?

[gmclelland]

Thanks, sure can. processwire/processwire-issues#408

[gmclelland]

Forgot to show what it looks like:

If I click the "Error in ProcesswireInfoPanel" it shows

ErrorException: count(): Parameter must be an array or an object that implements Countable in /Users/glenn/websites/pwoliver/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/panels/ProcesswireInfoPanel.php:198
Stack trace:
#0 /Users/glenn/websites/pwoliver/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/panels/ProcesswireInfoPanel.php(198): Tracy\Bar->Tracy\{closure}(2, 'count(): Parame...', '/Users/glenn/we...', 198, Array)
#1 /Users/glenn/websites/pwoliver/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-master/src/Tracy/Bar.php(159): ProcesswireInfoPanel->getPanel()
#2 /Users/glenn/websites/pwoliver/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-master/src/Tracy/Bar.php(108): Tracy\Bar->renderPanels()
#3 /Users/glenn/websites/pwoliver/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-master/src/Tracy/Debugger.php(272): Tracy\Bar->render()
#4 [internal function]: Tracy\Debugger::shutdownHandler()
#5 {main}

If I click on the "Error in DumpsRecorderPanel" it shows

ErrorException: count(): Parameter must be an array or an object that implements Countable in /Users/glenn/websites/pwoliver/wwwroot/site/modules/TracyDebugger/panels/DumpsRecorderPanel.php:15
Stack trace:
#0 /Users/glenn/websites/pwoliver/wwwroot/site/modules/TracyDebugger/panels/DumpsRecorderPanel.php(15): Tracy\Bar->Tracy\{closure}(2, 'count(): Parame...', '/Users/glenn/we...', 15, Array)
#1 /Users/glenn/websites/pwoliver/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-master/src/Tracy/Bar.php(158): DumpsRecorderPanel->getTab()
#2 /Users/glenn/websites/pwoliver/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-master/src/Tracy/Bar.php(108): Tracy\Bar->renderPanels()
#3 /Users/glenn/websites/pwoliver/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-master/src/Tracy/Debugger.php(272): Tracy\Bar->render()
#4 [internal function]: Tracy\Debugger::shutdownHandler()
#5 {main}

[adrianbj]

Yeah, thanks - I'll have a fix for these shortly - I am currently distracted on another issue ;)

[adrianbj]

These should all be fixed in: ccafb9f

Although there might be some others that show up in other circumstances so let me know if you find others.

Thanks again for reporting this.

[gmclelland]

👍

[gmclelland]

Found another bug in the Module Disabler Panel

ErrorException: count(): Parameter must be an array or an object that implements Countable in /Users/glenn/websites/mansfieldtexasarts/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/panels/ModuleDisablerPanel.php:110
Stack trace:
#0 /Users/glenn/websites/mansfieldtexasarts/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/panels/ModuleDisablerPanel.php(110): Tracy\Bar->Tracy\{closure}(2, 'count(): Parame...', '/Users/glenn/we...', 110, Array)
#1 /Users/glenn/websites/mansfieldtexasarts/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-master/src/Tracy/Bar.php(159): ModuleDisablerPanel->getPanel()
#2 /Users/glenn/websites/mansfieldtexasarts/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-master/src/Tracy/Bar.php(108): Tracy\Bar->renderPanels()
#3 /Users/glenn/websites/mansfieldtexasarts/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-master/src/Tracy/Debugger.php(272): Tracy\Bar->render()
#4 [internal function]: Tracy\Debugger::shutdownHandler()
#5 {main}

[adrianbj]

Hey @gmclelland - I can't reproduce this one, but I am thinking that changing this line:

TracyDebugger/TracyDebugger.module

Line 64 in ccafb9f

public static $disabableModules;

to: public static $disabableModules = array(); should fix it. Could you please try and let me know if that fixes things?

If it doesn't, any chance you could try to debug what \TracyDebugger::$disabableModules actually is just before line 110 in ModuleDisablerPanel.php please?

[gmclelland]

Changing the line to public static $disabableModules = array(); did the trick. No more error.

[gmclelland]

However, here is another that just popped up for Tracy Logs Panel

ErrorException: array_multisort(): Argument #1 is expected to be an array or a sort flag in /Users/glenn/websites/pwoliver/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/panels/TracyLogsPanel.php:90
Stack trace:
#0 [internal function]: Tracy\Bar->Tracy\{closure}(2, 'array_multisort...', '/Users/glenn/we...', 90, Array)
#1 /Users/glenn/websites/pwoliver/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/panels/TracyLogsPanel.php(90): array_multisort(NULL, 3, NULL, 3, Array)
#2 /Users/glenn/websites/pwoliver/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-master/src/Tracy/Bar.php(158): TracyLogsPanel->getTab()
#3 /Users/glenn/websites/pwoliver/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-master/src/Tracy/Bar.php(108): Tracy\Bar->renderPanels()
#4 /Users/glenn/websites/pwoliver/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-master/src/Tracy/Debugger.php(272): Tracy\Bar->render()
#5 [internal function]: Tracy\Debugger::shutdownHandler()
#6 {main}

[adrianbj]

However, here is another that just popped up for Tracy Logs Panel

Thanks - these should both be fixed in the latest version, even though I couldn't reproduce either of them, so please let me know, especially the array_multisort error.

[gmclelland]

I think that fixed the errors. However, I think I'm seeing major slow downs when browsing the admin pages. Strangely this only happens when using the Reno theme or Default classic theme. It doesn't happen when using the adminThemeUikit theme. Want me to open a new issue for this?

[gmclelland]

I'm not sure if this has anything do with it, but I thought I would share this: