fix race condition on ctx cancel#22
Merged
Merged
Conversation
jaimegago
changed the title
jaimegago
force-pushed
the
fix_race_condition
branch
from
b0ff398 to
9401ec5
Compare
jaimegago
force-pushed
the
fix_race_condition
branch
from
9401ec5 to
dd69481
Compare
Owner
|
YAY! THANKS A TON |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for race condition encountered in CLI that uses loop where /etc/hosts file entries added by the CLI are not cleaned up when exiting with CTRL+C/SIGINT.
Also added some logging around ignored errors.