Conversation
This reverts commit 4ce841f.
…hort syntax
for example, given the following code:
[A] class B {}
class AAttribute : System.Attribute {}
the order of processing would be as B, AAttribute instead of AAttribute, B
…hitecture Trying to run the assembly produced by the cecilified code on an arm64 fails with an error complaining about platform incompatibility.
Code around registering variables was very fragile; sometimes it used a open generic type's name (i.t, List<> when registering a variable for List<int>, some times the closed type name (i.e List<int> when processing List<int>), sometimes only the type simple name, etc... This commit also normalizes both the 'name' and 'parent name' to only use respecitively 'ITypeSymbol.OriginalDefinition.ToDisplayString()' and 'ITypeSymbol.ContainingSymbol.ToDisplayString()' and deviating from this only in cases that requires so. Ideally we should investigate and document such deviations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
01f9120 forwarded attribute reference with cycles (#311)
326683f set module architecture (either arm64 or amd64) after the runtime architecture
d072d0e added more generic attribute tests (#311)
fae791c fixes order of generated code when attributes were applied with its short syntax
ec7a009 adds support for null coalescing operator (only ??, not ??=) (#253)
1fd4e2b fixes stack underflow on local functions calls (#322)
eb3f37e Revert "fixes local functions always being handled as static (#271)"
dd4b9f5 bump cecilifier to 2.18.0