refactor: inject db/service into admin panel views#134
Merged
adrunkhuman merged 2 commits intomasterfrom Mar 21, 2026
Merged
Conversation
Replace admin_cog pass-through with direct dependency injection across all OwnerRestrictedView subclasses. Views now declare exactly what they need (db, service, bot) instead of reaching through the cog. - Remove TYPE_CHECKING guard and circular import workaround in all panel modules - OwnerRestrictedView: takes db, service, bot instead of admin_cog - OpenFixtureWarningView: inject start_fixture_dm callable instead of cog - FixtureSelect: remove open_only param (dead code; callers already pre-filter their fixture lists before calling update_options) - results.py ViewResultsButton: guard fixture None-check before get_results Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
railway-app
bot
temporarily deployed
to
patient-quietude / matchday-typer-pr-134
|
🚅 Deployed to the matchday-typer-pr-134 environment in patient-quietude
|
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
railway-app
bot
temporarily deployed
to
patient-quietude / matchday-typer-pr-134
adrunkhuman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OwnerRestrictedViewnow takesdb,service,botdirectly — no moreadmin_cogpass-throughOpenFixtureWarningViewinjectsstart_fixture_dm: Callableinstead of the whole cogFixtureSelect: removed deadopen_onlyparam — callers already pre-filter their fixture lists before callingupdate_optionsTYPE_CHECKINGguards and the circular import workaround removed across all 5 panel modulesViewResultsButton— movedfixture is Noneguard beforeget_resultsto avoid an unguarded DB call on a potentially deleted fixtureCloses #118
Test plan
/admin panelopens home view🤖 Generated with Claude Code