refactor: remove passthrough service methods#135
Merged
adrunkhuman merged 1 commit intomasterfrom Mar 21, 2026
Merged
Conversation
Delete AdminService.get_fixture_by_week (dead, zero external callers) and AdminService.get_recent_fixtures (pure proxy). Update PredictionsPanelView and ResultsPanelView to call self.db directly — both already hold db via OwnerRestrictedView. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
railway-app
bot
temporarily deployed
to
patient-quietude / matchday-typer-pr-135
|
🚅 Deployed to the matchday-typer-pr-135 environment in patient-quietude
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #133
Summary
AdminService.get_fixture_by_week— zero external callers, dead methodAdminService.get_recent_fixtures— purereturn await self.db.*proxy with no added valuePredictionsPanelView.load_fixture_optionsandResultsPanelView.load_fixture_optionsto callself.db.get_recent_fixturesdirectly (both views already holddbviaOwnerRestrictedView)Audited all remaining
AdminServicemethods — none are passthroughs. Every remaining method orchestrates multiple DB calls, enforces business rules, or composes operations.Test plan
/admin panel→ Predictions tab loads fixture dropdown correctly/admin panel→ Results tab loads fixture dropdown correctly🤖 Generated with Claude Code