SCIX-692 fix: TimeSince component showing epoch dates for invalid input#730
Merged
thostetler merged 1 commit intoadsabs:masterfrom Dec 16, 2025
Conversation
Fixed bug where TimeSince would throw RangeError or display 1970 dates when given invalid/empty date strings. - Added null/undefined/empty string validation to prevent epoch date display - Improved date parsing to handle both positive and negative timezone offsets - Added support for ISO dates without time portions - Improved TypeScript type safety with TimeSinceProps interface - Added comprehensive test coverage with 16 tests covering edge cases
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #730 +/- ##
========================================
+ Coverage 70.1% 70.1% +0.1%
========================================
Files 218 218
Lines 24126 24124 -2
Branches 1287 1294 +7
========================================
+ Hits 16895 16904 +9
+ Misses 7196 7185 -11
Partials 35 35
🚀 New features to boost your workflow:
|
shinyichen
approved these changes
Dec 11, 2025
thostetler
deleted the
SCIX-692/Time-Since-showing-weird-values-for-some-users
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed bug where TimeSince would throw RangeError or display 1970 dates when given invalid/empty date strings.