Skip to content

Remove n param from url#734

Merged
thostetler merged 1 commit intoadsabs:masterfrom
shinyichen:SCIX-699-incorrect-n-param-fix
Dec 16, 2025
Merged

Remove n param from url#734
thostetler merged 1 commit intoadsabs:masterfrom
shinyichen:SCIX-699-incorrect-n-param-fix

Conversation

@shinyichen
Copy link
Member

Remove n param from URL since it is not used anywhere and also doesn't corresponding to the actual page numbers in the results.

Copy link
Member

@thostetler thostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable until we start doing more server side fetches from the API. 👍

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.1%. Comparing base (95059b0) to head (6b576bb).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #734     +/-   ##
========================================
- Coverage    70.1%   70.1%   -0.0%     
========================================
  Files         218     218             
  Lines       24126   24124      -2     
  Branches     1287    1287             
========================================
- Hits        16896   16890      -6     
- Misses       7195    7199      +4     
  Partials       35      35             
Files with missing lines Coverage Δ
src/utils/common/search.ts 95.5% <100.0%> (-<0.1%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thostetler thostetler merged commit f69a416 into adsabs:master Dec 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants